Skip to content

[Merged by Bors] - feat: Fourier integral of Gaussians on inner product spaces#11035

Closed
sgouezel wants to merge 4 commits intomasterfrom
SG_gaussian
Closed

[Merged by Bors] - feat: Fourier integral of Gaussians on inner product spaces#11035
sgouezel wants to merge 4 commits intomasterfrom
SG_gaussian

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

Also rename (and deprecate) a few statements by changing fourierTransform to fourierIntegral: the Fourier transform for general L^2 functions is not given by the Fourier integral, so we should separate cleanly the two of them.


Open in Gitpod

@loefflerd
Copy link
Copy Markdown
Contributor

I'm not sure I entirely get the argument about renaming – the Fourier transform is given by the integral for L^1 functions, and Gaussians are about the most L^1 function you can imagine! But if you really want to rename the lemmas then go ahead, I'm not fanatically attached to the old names.

As for the inner-product space results: would it be significantly harder to treat the more general case of "ellipsoidal" rather than "spherical" Gaussians, i.e. exp(-∑ i, b i * (v i : ℂ) ^ 2 + ...) for some b : ι → ℂ, and then derive the case of constant b as a consequence? It seems to me that the proof you use would extend immediately to this case as well.

@sgouezel
Copy link
Copy Markdown
Contributor Author

sgouezel commented Mar 4, 2024

About the naming, I expect that in the not so distant future we will define the Fourier transform of a general function f : E -> ℂ, maybe as follows: if f is integrable against any Schwartz function and there exists a measurable g such that ∫ f ⬝ 𝓕 φ = ∫ g • φ for all Schwartz function, then use this g (or, better, if there is such a g which is continuous, then use the continuous version, and otherwise use the measurable one). This is what I would like to call the Fourier transform (in particular, it would work fine on L^2), and anticipating on this one I would like to use fourierTransform for lemmas about this one, and fourierIntegral for lemmas about the Fourier integral. I agree it's not essential, but planning a little bit ahead can help having a nice library.

Let me try to do the ellipsoidal Gaussian.

@sgouezel
Copy link
Copy Markdown
Contributor Author

sgouezel commented Mar 4, 2024

Ellipsoidal case done.

@loefflerd
Copy link
Copy Markdown
Contributor

Looks great! We should probably change the section title

/-! ## Fourier transform of the Gaussian integral
-/

to something like "Fourier integral of the Gaussian function" for consistency with the lemma renamings (the original title is clearly a mistake anyway). Other than that I have nothing further to add.

@sgouezel
Copy link
Copy Markdown
Contributor Author

sgouezel commented Mar 4, 2024

Good remark. I've changed the section title accordingly, to Fourier integral of Gaussian functions.

Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2024

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 4, 2024
@RemyDegenne
Copy link
Copy Markdown
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2024
Also rename (and deprecate) a few statements by changing `fourierTransform` to `fourierIntegral`: the Fourier transform for general L^2 functions is not given by the Fourier integral, so we should separate cleanly the two of them.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Fourier integral of Gaussians on inner product spaces [Merged by Bors] - feat: Fourier integral of Gaussians on inner product spaces Mar 4, 2024
@mathlib-bors mathlib-bors bot closed this Mar 4, 2024
@mathlib-bors mathlib-bors bot deleted the SG_gaussian branch March 4, 2024 21:57
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Also rename (and deprecate) a few statements by changing `fourierTransform` to `fourierIntegral`: the Fourier transform for general L^2 functions is not given by the Fourier integral, so we should separate cleanly the two of them.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Also rename (and deprecate) a few statements by changing `fourierTransform` to `fourierIntegral`: the Fourier transform for general L^2 functions is not given by the Fourier integral, so we should separate cleanly the two of them.
utensil pushed a commit that referenced this pull request Mar 26, 2024
Also rename (and deprecate) a few statements by changing `fourierTransform` to `fourierIntegral`: the Fourier transform for general L^2 functions is not given by the Fourier integral, so we should separate cleanly the two of them.
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Also rename (and deprecate) a few statements by changing `fourierTransform` to `fourierIntegral`: the Fourier transform for general L^2 functions is not given by the Fourier integral, so we should separate cleanly the two of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants