[Merged by Bors] - chore: add instance from Nat.AtLeastTwo n to NeZero n#10964
Closed
[Merged by Bors] - chore: add instance from Nat.AtLeastTwo n to NeZero n#10964
Nat.AtLeastTwo n to NeZero n#10964Conversation
Closed
1 task
eric-wieser
reviewed
Feb 25, 2024
Member
|
!bench |
Collaborator
|
Here are the benchmark results for commit 8bb99c1. |
Member
|
bors d+ after the change above |
Contributor
|
✌️ timotree3 can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2024
This PR cleans up some lemmas where we're taking named instance parameters `[h : Nat.AtLeastTwo n]` and manually proving inequalities like `0 < n` from `h` by adding an instance of `NeZero n` from `Nat.AtLeastTwo n` as well as a couple of other helper lemmas. This removes `Nat.AtLeastTwo.ne_zero`, as `NeZero.ne_zero` replaces it.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Nat.AtLeastTwo n to NeZero nNat.AtLeastTwo n to NeZero n
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
This PR cleans up some lemmas where we're taking named instance parameters `[h : Nat.AtLeastTwo n]` and manually proving inequalities like `0 < n` from `h` by adding an instance of `NeZero n` from `Nat.AtLeastTwo n` as well as a couple of other helper lemmas. This removes `Nat.AtLeastTwo.ne_zero`, as `NeZero.ne_zero` replaces it.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR cleans up some lemmas where we're taking named instance parameters `[h : Nat.AtLeastTwo n]` and manually proving inequalities like `0 < n` from `h` by adding an instance of `NeZero n` from `Nat.AtLeastTwo n` as well as a couple of other helper lemmas. This removes `Nat.AtLeastTwo.ne_zero`, as `NeZero.ne_zero` replaces it.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR cleans up some lemmas where we're taking named instance parameters `[h : Nat.AtLeastTwo n]` and manually proving inequalities like `0 < n` from `h` by adding an instance of `NeZero n` from `Nat.AtLeastTwo n` as well as a couple of other helper lemmas. This removes `Nat.AtLeastTwo.ne_zero`, as `NeZero.ne_zero` replaces it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up some lemmas where we're taking named instance parameters
[h : Nat.AtLeastTwo n]and manually proving inequalities like0 < nfromhby adding an instance ofNeZero nfromNat.AtLeastTwo nas well as a couple of other helper lemmas.This removes
Nat.AtLeastTwo.ne_zero, asNeZero.ne_zeroreplaces it.Split from #8006.