Skip to content

[Merged by Bors] - feat: port Algebra.Parity#1092

Closed
siddhartha-gadgil wants to merge 54 commits intomasterfrom
algebra_parity
Closed

[Merged by Bors] - feat: port Algebra.Parity#1092
siddhartha-gadgil wants to merge 54 commits intomasterfrom
algebra_parity

Conversation

@siddhartha-gadgil
Copy link
Copy Markdown
Collaborator

@siddhartha-gadgil siddhartha-gadgil commented Dec 18, 2022

dcf2250875895376a142faeeac5eabff32c48655

@kim-em kim-em added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 18, 2022
@kim-em kim-em removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 19, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Dec 19, 2022

This PR/issue depends on:

-- "Alias of the backwards direction of\n`even_iff_exists_two_nsmul`."]
-- is_square_of_exists_sq

-- @[to_additive Even.nsmul]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these commented out?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simps were removed because of redundancy reported by the linter. Others attributes were probably accidentally deleted.

@siddhartha-gadgil siddhartha-gadgil removed the request for review from Ruben-VandeVelde December 19, 2022 15:25
@ChrisHughes24
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 19, 2022
bors bot pushed a commit that referenced this pull request Dec 19, 2022
dcf2250875895376a142faeeac5eabff32c48655

- [x] depends on: #1055 

Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Dec 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Parity [Merged by Bors] - feat: port Algebra.Parity Dec 19, 2022
@bors bors bot closed this Dec 19, 2022
@bors bors bot deleted the algebra_parity branch December 19, 2022 15:52
bors bot pushed a commit that referenced this pull request Dec 20, 2022
dcf2250875895376a142faeeac5eabff32c48655

* [x] depends on #1055
* [x] depends on #1092

Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants