[Merged by Bors] - chore: remove duplicated namespaces from instances#10899
Closed
Ruben-VandeVelde wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: remove duplicated namespaces from instances#10899Ruben-VandeVelde wants to merge 2 commits intomasterfrom
Ruben-VandeVelde wants to merge 2 commits intomasterfrom
Conversation
Contributor
Ruben-VandeVelde
commented
Feb 23, 2024
Member
|
We don't want this to fire on autogenerated instance names. Do you know whether that is possible or likely with this change? |
Contributor
Author
|
Note that this PR only contains the code changes, not the linter. I think we should land this regardless of what happens to the linter change. |
Member
|
I agree the we have a separate problem, but this LGTM, thanks! bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.