Skip to content

[Merged by Bors] - feat(Algebra/Homology): behaviour of the total complex with respect to the shifts#10854

Closed
joelriou wants to merge 23 commits intomasterfrom
total-complex-shift
Closed

[Merged by Bors] - feat(Algebra/Homology): behaviour of the total complex with respect to the shifts#10854
joelriou wants to merge 23 commits intomasterfrom
total-complex-shift

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Feb 22, 2024

@joelriou joelriou added the t-category-theory Category theory label Feb 22, 2024
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 22, 2024
@joelriou joelriou changed the title feat(Algebra/Homology): behaviour of the total complex with the shift on the first variable feat(Algebra/Homology): behaviour of the total complex with the shifts Feb 22, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 23, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 23, 2024
@joelriou joelriou changed the title feat(Algebra/Homology): behaviour of the total complex with the shifts feat(Algebra/Homology): behaviour of the total complex with respect to the shifts Feb 23, 2024
@ghost ghost added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Mar 12, 2024
@ghost
Copy link
Copy Markdown

ghost commented Mar 12, 2024

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 13, 2024
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Mar 18, 2024
@joelriou joelriou added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Mar 18, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 18, 2024
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors d+

simp only [ι_totalDesc_assoc, CochainComplex.shiftFunctor_obj_X', ι_totalDesc, comp_id]
exact ((shiftFunctor₁ C x).obj K).XXIsoOfEq_inv_ιTotal _ (by omega) rfl _ _

lemma D₁_totalShift₁XIso_hom (n₀ n₁ n₀' n₁' : ℤ) (h₀ : n₀ + x = n₀') (h₁ : n₁ + x = n₁') :
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one and the lemma below are also missing @[reassoc]?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 19, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Mar 19, 2024
@joelriou
Copy link
Copy Markdown
Contributor Author

Thanks for the review!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 19, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Homology): behaviour of the total complex with respect to the shifts [Merged by Bors] - feat(Algebra/Homology): behaviour of the total complex with respect to the shifts Mar 19, 2024
@mathlib-bors mathlib-bors bot closed this Mar 19, 2024
@mathlib-bors mathlib-bors bot deleted the total-complex-shift branch March 19, 2024 11:22
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
utensil pushed a commit that referenced this pull request Mar 26, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants