[Merged by Bors] - chore: move #guard_msgs in PosDef to test file#10827
Closed
[Merged by Bors] - chore: move #guard_msgs in PosDef to test file#10827
Conversation
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
This PR introduces an `awk`-based linter for checking that `Mathlib/*.lean` files do not contain `#`-commands. It takes the names of the commands that begin with `#` by running ```lean import Mathlib #help command ``` and after that it is all text-based substitutions. It triggers an error on lines that begin with `#cmd`, omitting (most) lines contained comment blocks. CI for this PR should fail until #10772 and #10827 have been merged.
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
This PR introduces an `awk`-based linter for checking that `Mathlib/*.lean` files do not contain `#`-commands. It takes the names of the commands that begin with `#` by running ```lean import Mathlib #help command ``` and after that it is all text-based substitutions. It triggers an error on lines that begin with `#cmd`, omitting (most) lines contained comment blocks. CI for this PR should fail until #10772 and #10827 have been merged.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
This PR introduces an `awk`-based linter for checking that `Mathlib/*.lean` files do not contain `#`-commands. It takes the names of the commands that begin with `#` by running ```lean import Mathlib #help command ``` and after that it is all text-based substitutions. It triggers an error on lines that begin with `#cmd`, omitting (most) lines contained comment blocks. CI for this PR should fail until #10772 and #10827 have been merged.
adomani
added a commit
that referenced
this pull request
Feb 27, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
This PR introduces an `awk`-based linter for checking that `Mathlib/*.lean` files do not contain `#`-commands. It takes the names of the commands that begin with `#` by running ```lean import Mathlib #help command ``` and after that it is all text-based substitutions. It triggers an error on lines that begin with `#cmd`, omitting (most) lines contained comment blocks. CI for this PR should fail until #10772 and #10827 have been merged.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR introduces an `awk`-based linter for checking that `Mathlib/*.lean` files do not contain `#`-commands. It takes the names of the commands that begin with `#` by running ```lean import Mathlib #help command ``` and after that it is all text-based substitutions. It triggers an error on lines that begin with `#cmd`, omitting (most) lines contained comment blocks. CI for this PR should fail until #10772 and #10827 have been merged.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR moves a `#guard_msgs` command from `LinearAlgebra/Matrix/PosDef` to a test file: it is a preparation for #10809.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
This PR introduces an `awk`-based linter for checking that `Mathlib/*.lean` files do not contain `#`-commands. It takes the names of the commands that begin with `#` by running ```lean import Mathlib #help command ``` and after that it is all text-based substitutions. It triggers an error on lines that begin with `#cmd`, omitting (most) lines contained comment blocks. CI for this PR should fail until #10772 and #10827 have been merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves a
#guard_msgscommand fromLinearAlgebra/Matrix/PosDefto a test file: it is a preparation for #10809.