[Merged by Bors] - chore: remove terminal, terminal refines#10762
Closed
[Merged by Bors] - chore: remove terminal, terminal refines#10762
refines#10762Conversation
refines
Member
|
Thanks! bors merge |
Contributor
Author
|
@fpvandoorn I merged the new master into this PR to fix the conflicts, but there were none. Should I push the merge? |
Member
|
If there is no merge conflict with master, then there is no point pushing (and it might cancel a bors run). It conflicts with another PR in the same batch. bors d+ |
Contributor
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
I replaced a few "terminal" `refine/refine'`s with `exact`. The strategy was very simple-minded: essentially any `refine` whose following line had smaller indentation got replaced by `exact` and then I cleaned up the mess. This PR certainly leaves some further terminal `refine`s, but maybe the current change is beneficial.
Member
|
bors r- |
Contributor
|
Canceled. |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
I replaced a few "terminal" `refine/refine'`s with `exact`. The strategy was very simple-minded: essentially any `refine` whose following line had smaller indentation got replaced by `exact` and then I cleaned up the mess. This PR certainly leaves some further terminal `refine`s, but maybe the current change is beneficial.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
refinesrefines
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
I replaced a few "terminal" `refine/refine'`s with `exact`. The strategy was very simple-minded: essentially any `refine` whose following line had smaller indentation got replaced by `exact` and then I cleaned up the mess. This PR certainly leaves some further terminal `refine`s, but maybe the current change is beneficial.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
I replaced a few "terminal" `refine/refine'`s with `exact`. The strategy was very simple-minded: essentially any `refine` whose following line had smaller indentation got replaced by `exact` and then I cleaned up the mess. This PR certainly leaves some further terminal `refine`s, but maybe the current change is beneficial.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
I replaced a few "terminal" `refine/refine'`s with `exact`. The strategy was very simple-minded: essentially any `refine` whose following line had smaller indentation got replaced by `exact` and then I cleaned up the mess. This PR certainly leaves some further terminal `refine`s, but maybe the current change is beneficial.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
I replaced a few "terminal" `refine/refine'`s with `exact`. The strategy was very simple-minded: essentially any `refine` whose following line had smaller indentation got replaced by `exact` and then I cleaned up the mess. This PR certainly leaves some further terminal `refine`s, but maybe the current change is beneficial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced a few "terminal"
refine/refine's withexact.The strategy was very simple-minded: essentially any
refinewhose following line had smaller indentation got replaced byexactand then I cleaned up the mess.This PR certainly leaves some further terminal
refines, but maybe the current change is beneficial.