Skip to content

[Merged by Bors] - move: Algebraic pi instances#10693

Closed
YaelDillies wants to merge 2 commits intomasterfrom
move_algebra_group_pi
Closed

[Merged by Bors] - move: Algebraic pi instances#10693
YaelDillies wants to merge 2 commits intomasterfrom
move_algebra_group_pi

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

Rename

  • Data.Pi.Algebra to Algebra.Group.Pi.Basic
  • Algebra.Group.Pi to Algebra.Group.Pi.Lemmas

Move a few instances from the latter to the former, the goal being that Algebra.Group.Pi.Basic is about all the pi instances of the classes defined in Algebra.Group.Defs. Algebra.Group.Pi.Lemmas will need further rearranging.


Open in Gitpod

Rename
* `Data.Pi.Algebra` to `Algebra.Group.Pi.Basic`
* `Algebra.Group.Pi` to `Algebra.Group.Pi.Lemmas`

Move a few instances from the latter to the former, the goal being that `Algebra.Group.Pi.Basic` is about all the pi instances of the classes defined in `Algebra.Group.Defs`. `Algebra.Group.Pi.Lemmas` will need further rearranging.
@YaelDillies YaelDillies added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Feb 18, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 18, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 20, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
Rename
* `Data.Pi.Algebra` to `Algebra.Group.Pi.Basic`
* `Algebra.Group.Pi` to `Algebra.Group.Pi.Lemmas`

Move a few instances from the latter to the former, the goal being that `Algebra.Group.Pi.Basic` is about all the pi instances of the classes defined in `Algebra.Group.Defs`. `Algebra.Group.Pi.Lemmas` will need further rearranging.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title move: Algebraic pi instances [Merged by Bors] - move: Algebraic pi instances Feb 20, 2024
@mathlib-bors mathlib-bors bot closed this Feb 20, 2024
@mathlib-bors mathlib-bors bot deleted the move_algebra_group_pi branch February 20, 2024 11:30
thorimur pushed a commit that referenced this pull request Feb 24, 2024
Rename
* `Data.Pi.Algebra` to `Algebra.Group.Pi.Basic`
* `Algebra.Group.Pi` to `Algebra.Group.Pi.Lemmas`

Move a few instances from the latter to the former, the goal being that `Algebra.Group.Pi.Basic` is about all the pi instances of the classes defined in `Algebra.Group.Defs`. `Algebra.Group.Pi.Lemmas` will need further rearranging.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
Rename
* `Data.Pi.Algebra` to `Algebra.Group.Pi.Basic`
* `Algebra.Group.Pi` to `Algebra.Group.Pi.Lemmas`

Move a few instances from the latter to the former, the goal being that `Algebra.Group.Pi.Basic` is about all the pi instances of the classes defined in `Algebra.Group.Defs`. `Algebra.Group.Pi.Lemmas` will need further rearranging.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Rename
* `Data.Pi.Algebra` to `Algebra.Group.Pi.Basic`
* `Algebra.Group.Pi` to `Algebra.Group.Pi.Lemmas`

Move a few instances from the latter to the former, the goal being that `Algebra.Group.Pi.Basic` is about all the pi instances of the classes defined in `Algebra.Group.Defs`. `Algebra.Group.Pi.Lemmas` will need further rearranging.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Rename
* `Data.Pi.Algebra` to `Algebra.Group.Pi.Basic`
* `Algebra.Group.Pi` to `Algebra.Group.Pi.Lemmas`

Move a few instances from the latter to the former, the goal being that `Algebra.Group.Pi.Basic` is about all the pi instances of the classes defined in `Algebra.Group.Defs`. `Algebra.Group.Pi.Lemmas` will need further rearranging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants