[Merged by Bors] - chore: remove stream-of-consciousness uses of have, replace and suffices#10640
Closed
[Merged by Bors] - chore: remove stream-of-consciousness uses of have, replace and suffices#10640
have, replace and suffices#10640Conversation
This syntax remains available downstream with `import Mathlib.Tactic`, but is not available in mathlib
…eanprover-community/mathlib4 into eric-wieser/remove-tactic.Have
Closed
1 task
eric-wieser
approved these changes
Feb 16, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
I have not read the diff, but I am keen in principle to get this merged.
Contributor
Author
|
I have reverted the two noisy tests to the previous versions, which are non-noisy but use the old-fashioned have. I think this shouldn't block this PR, since remaining issues can be discussed in #10534 while here we are just doing a cleanup of the library, which doesn't have to be complete. |
Contributor
|
bors merge |
Member
Contributor
|
Pull request successfully merged into master. Build succeeded: |
have, replace and sufficeshave, replace and suffices
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…mathlib (#10534) This syntax remains available downstream with `import Mathlib.Tactic`, but is no longer available in mathlib itself. This follows on from #10640, which remove all current uses of this syntax. By removing these imports, we prevent further regressions in mathlib, and save reviewers from having to look out for this in review. In future we could delete this syntax entirely, but this would harm downstream code, especially mathport output. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…mathlib (#10534) This syntax remains available downstream with `import Mathlib.Tactic`, but is no longer available in mathlib itself. This follows on from #10640, which remove all current uses of this syntax. By removing these imports, we prevent further regressions in mathlib, and save reviewers from having to look out for this in review. In future we could delete this syntax entirely, but this would harm downstream code, especially mathport output. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
…mathlib (#10534) This syntax remains available downstream with `import Mathlib.Tactic`, but is no longer available in mathlib itself. This follows on from #10640, which remove all current uses of this syntax. By removing these imports, we prevent further regressions in mathlib, and save reviewers from having to look out for this in review. In future we could delete this syntax entirely, but this would harm downstream code, especially mathport output. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
…mathlib (#10534) This syntax remains available downstream with `import Mathlib.Tactic`, but is no longer available in mathlib itself. This follows on from #10640, which remove all current uses of this syntax. By removing these imports, we prevent further regressions in mathlib, and save reviewers from having to look out for this in review. In future we could delete this syntax entirely, but this would harm downstream code, especially mathport output. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
…mathlib (#10534) This syntax remains available downstream with `import Mathlib.Tactic`, but is no longer available in mathlib itself. This follows on from #10640, which remove all current uses of this syntax. By removing these imports, we prevent further regressions in mathlib, and save reviewers from having to look out for this in review. In future we could delete this syntax entirely, but this would harm downstream code, especially mathport output. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…mathlib (#10534) This syntax remains available downstream with `import Mathlib.Tactic`, but is no longer available in mathlib itself. This follows on from #10640, which remove all current uses of this syntax. By removing these imports, we prevent further regressions in mathlib, and save reviewers from having to look out for this in review. In future we could delete this syntax entirely, but this would harm downstream code, especially mathport output. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes to tactic file, it's just boring fixes throughout the library.
This follows on from #6964.
The fixes have been found by disabling the tactics, in #10534, but the current PR does not touch the tactic files to make it easier to review and uncontroversial.
After this PR, there are just two remaining uses of the old style
have, intest/slim_check, which I don't know how to convert to the new style without making them noisy (plus the other ones that will have been introduced to master in between!)