Conversation
I think if Real.exp_nonneg exists as a separate lemma, Real.pi_nonneg is reasonable. And it's useful as a separate lemma for Aesop purposes too.
Closed
1 task
Real.pi_nonneg = Real.pi_pos.le
adomani
reviewed
Feb 15, 2024
Contributor
|
I am not sure where to draw the line on lemmas about "important" constants. In particular, on the one hand, I understand that these lemmas can be helpful for certain tactics, on the other hand these lemmas also seem the ones that automation could make obsolete! I'm pinging @urkud and @sgouezel who can make a more informed decision about this PR. |
Contributor
|
This one will show up so often that it's definitely worth having explicitely. Thanks! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Real.pi_nonneg = Real.pi_pos.leReal.pi_nonneg = Real.pi_pos.le
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think if
Real.exp_nonnegexists as a separate lemma,Real.pi_nonnegis reasonable. And it's useful as a separate lemma for Aesop purposes too.