[Merged by Bors] - feat: port Data.String.Basic#1054
Closed
Conversation
Collaborator
Author
|
Finished the missing proof now, so it's only some simp lemmas left now |
…unity/mathlib4 into port-data-string-basic-2
Added a few lemmas needed. TODO: definitely needs clean-up and re-structure after we finish all proofs.
eric-wieser
reviewed
Feb 13, 2023
Indent a line in the code.
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
mathlib3 SHA: 8a275d92e9f9f3069871cbdf0ddd54b88c17e144 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com> Co-authored-by: Maxwell Thum <maxwell.thum2718@gmail.com> Co-authored-by: casavaca <96765450+casavaca@users.noreply.github.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com>
|
Build failed: |
chabulhwi
reviewed
Apr 5, 2023
Take `compare` to be `compareOfLessAndEq`.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
mathlib3 SHA: 8a275d92e9f9f3069871cbdf0ddd54b88c17e144 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com> Co-authored-by: Maxwell Thum <maxwell.thum2718@gmail.com> Co-authored-by: casavaca <96765450+casavaca@users.noreply.github.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com>
|
Pull request successfully merged into master. Build succeeded: |
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
mathlib3 SHA: 8a275d92e9f9f3069871cbdf0ddd54b88c17e144 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com> Co-authored-by: Maxwell Thum <maxwell.thum2718@gmail.com> Co-authored-by: casavaca <96765450+casavaca@users.noreply.github.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com>
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
mathlib3 SHA: 8a275d92e9f9f3069871cbdf0ddd54b88c17e144 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com> Co-authored-by: Maxwell Thum <maxwell.thum2718@gmail.com> Co-authored-by: casavaca <96765450+casavaca@users.noreply.github.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3 SHA: d13b3a4a392ea7273dfa4727dbd1892e26cfd518