[Merged by Bors] - feat: Boxes in locally finite ordered rings#10506
Closed
YaelDillies wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat: Boxes in locally finite ordered rings#10506YaelDillies wants to merge 4 commits intomasterfrom
YaelDillies wants to merge 4 commits intomasterfrom
Conversation
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
5 tasks
CBirkbeck
reviewed
Feb 13, 2024
| refine tsub_eq_of_eq_add ?_ | ||
| zify | ||
| ring | ||
|
|
Collaborator
There was a problem hiding this comment.
can you add the result that box 0 has size 1?
Contributor
Author
There was a problem hiding this comment.
No need. simp already knows that: (box 0).card = {0}.card = 1
Collaborator
|
LGTM but maybe get a pro to review it as well.. |
riccardobrasca
approved these changes
Feb 18, 2024
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes" `Icc (-n) n`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the sequence of "hollow boxes" indexed by natural numbers as the successive differences of the "boxes"
Icc (-n) n.This will be useful for both percolation in ℤᵈ and for bounding Eisenstein series in ℤ²