[Merged by Bors] - chore(NNRat): Rearrange imports#10392
Closed
YaelDillies wants to merge 11 commits intomasterfrom
Closed
[Merged by Bors] - chore(NNRat): Rearrange imports#10392YaelDillies wants to merge 11 commits intomasterfrom
YaelDillies wants to merge 11 commits intomasterfrom
Conversation
The goal is to separate the field material on `Rat`/`NNRat` from everything before. We achieve this by * splitting `Data.Rat.NNRat` into * `Data.NNRat.Defs` for the foundationl stuff that will be needed in the definition of `Field` * `Data.NNRat.Lemmas` for the field and big operators material * moving the field material from `Data.Rat.Order` to `Data.Rat.Basic` * proving a few lemmas by `rfl` rather than `coeHom.some_now_unavailable_lemma` * renaming `Data.Rat.NNRat.BigOperators` to `Data.NNRat.BigOperators`
eric-wieser
reviewed
Feb 9, 2024
eric-wieser
reviewed
Feb 9, 2024
eric-wieser
reviewed
Feb 9, 2024
eric-wieser
reviewed
Feb 9, 2024
Member
There was a problem hiding this comment.
Perhaps this should be called NNRat/Field?
Contributor
Author
There was a problem hiding this comment.
There's more than just the field instance, though?
eric-wieser
reviewed
Feb 10, 2024
eric-wieser
reviewed
Feb 10, 2024
eric-wieser
reviewed
Feb 11, 2024
eric-wieser
reviewed
Feb 11, 2024
eric-wieser
reviewed
Feb 11, 2024
eric-wieser
approved these changes
Feb 11, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
The Lemmas file feels a bit messy to me (aesthetically I'd prefer to see Field to match Rat, and a separate Lemmas file), but since nothing in practice actually motivates that split I'm fine with a single Lemmas file.
I'll maintainer merge this to let someone else take a look once you've addressed my remaining minor comments.
eric-wieser
reviewed
Feb 11, 2024
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
The goal is to separate the field material on `Rat`/`NNRat` from everything before to make way for `NNRat.cast`. We achieve this by * splitting `Data.Rat.NNRat` into * `Data.NNRat.Defs` for the foundationl stuff that will be needed in the definition of `Field` * `Data.NNRat.Lemmas` for the field and big operators material * moving the field material from `Data.Rat.Order` to `Data.Rat.Basic` * proving a few lemmas by `rfl` rather than `coeHom.some_now_unavailable_lemma` * renaming `Data.Rat.NNRat.BigOperators` to `Data.NNRat.BigOperators`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
The goal is to separate the field material on `Rat`/`NNRat` from everything before to make way for `NNRat.cast`. We achieve this by * splitting `Data.Rat.NNRat` into * `Data.NNRat.Defs` for the foundationl stuff that will be needed in the definition of `Field` * `Data.NNRat.Lemmas` for the field and big operators material * moving the field material from `Data.Rat.Order` to `Data.Rat.Basic` * proving a few lemmas by `rfl` rather than `coeHom.some_now_unavailable_lemma` * renaming `Data.Rat.NNRat.BigOperators` to `Data.NNRat.BigOperators`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to separate the field material on
Rat/NNRatfrom everything before to make way forNNRat.cast. We achieve this byData.Rat.NNRatintoData.NNRat.Defsfor the foundationl stuff that will be needed in the definition ofFieldData.NNRat.Lemmasfor the field and big operators materialData.Rat.OrdertoData.Rat.Basicrflrather thancoeHom.some_now_unavailable_lemmaData.Rat.NNRat.BigOperatorstoData.NNRat.BigOperatorsThis is a rehash of leanprover-community/mathlib3#18609.