Skip to content

[Merged by Bors] - chore: Move positivity extensions#10140

Closed
YaelDillies wants to merge 8 commits intomasterfrom
move_positivity_ext
Closed

[Merged by Bors] - chore: Move positivity extensions#10140
YaelDillies wants to merge 8 commits intomasterfrom
move_positivity_ext

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

The goal here is to have access to positivity earlier in the import hierarchy


Open in Gitpod

The goal here is to have access to `positivity` earlier in the import hierarchy
@urkud
Copy link
Copy Markdown
Member

urkud commented Feb 1, 2024

AFAIR, @semorrison removed some dependencies on positivity in a recent PR. Please coordinate.

@YaelDillies
Copy link
Copy Markdown
Contributor Author

You're thinking of #9924. The current PR already builds on top of that one.

@YaelDillies YaelDillies requested a review from kim-em February 3, 2024 08:31
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 4, 2024

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 4, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Feb 4, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 5, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 5, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Feb 5, 2024

(Sorry, intended to merge the first time, fingers just remembered d+ instead of r+.)

mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2024
The goal here is to have access to `positivity` earlier in the import hierarchy
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 5, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2024
The goal here is to have access to `positivity` earlier in the import hierarchy
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 5, 2024

Build failed:

  • Build

@YaelDillies
Copy link
Copy Markdown
Contributor Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2024
The goal here is to have access to `positivity` earlier in the import hierarchy
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Move positivity extensions [Merged by Bors] - chore: Move positivity extensions Feb 5, 2024
@mathlib-bors mathlib-bors bot closed this Feb 5, 2024
@mathlib-bors mathlib-bors bot deleted the move_positivity_ext branch February 5, 2024 14:11
Vierkantor pushed a commit that referenced this pull request Feb 5, 2024
The goal here is to have access to `positivity` earlier in the import hierarchy
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
The goal here is to have access to `positivity` earlier in the import hierarchy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants