[Merged by Bors] - fix(TopologicalSpace/Basic): restore curly braces in continuous_def#10110
Closed
[Merged by Bors] - fix(TopologicalSpace/Basic): restore curly braces in continuous_def#10110
continuous_def#10110Conversation
These were placed on purpose; reverting them caused breakage downstream.
alreadydone
reviewed
Jan 29, 2024
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
dwrensha
approved these changes
Jan 30, 2024
dwrensha
reviewed
Jan 30, 2024
Mathlib/Topology/Basic.lean
Outdated
| theorem continuous_def : Continuous f ↔ ∀ s, IsOpen s → IsOpen (f ⁻¹' s) := | ||
| -- The curly braces are intentional, so this definitions works well with simp | ||
| -- when topologies are not those provided by instances. | ||
| theorem continuous_def {_ : TopologicalSpace X} {_ : TopologicalSpace Y} : |
Member
There was a problem hiding this comment.
I don't know whether this is necessarily the right thing to do (my downstream code does not care one way or the other), but I just wanted to note: to fully revert the change, you would need to re-add the {f : X → Y} parameter here after the TopologicalSpace parameters. Then I think you would not need the other changes in Order.lean.
mathlib4/Mathlib/Topology/Basic.lean
Lines 1631 to 1632 in e7170d3
Contributor
There was a problem hiding this comment.
Indeed, I think it's better to have f come last.
Contributor
Author
There was a problem hiding this comment.
Fair point. I have changed the order.
dwrensha
approved these changes
Feb 10, 2024
Member
|
I'm sorry for merging #9993 too soon. |
Member
|
bors d=Ruben-VandeVelde |
Contributor
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
I have incorporated the suggestion and merged master. |
urkud
reviewed
Feb 16, 2024
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
…#10110) These were placed on purpose; reverting them caused breakage downstream. Co-authored-by: grunweg <grunweg@posteo.de> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
continuous_defcontinuous_def
riccardobrasca
pushed a commit
that referenced
this pull request
Feb 18, 2024
…#10110) These were placed on purpose; reverting them caused breakage downstream. Co-authored-by: grunweg <grunweg@posteo.de> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…#10110) These were placed on purpose; reverting them caused breakage downstream. Co-authored-by: grunweg <grunweg@posteo.de> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were placed on purpose; reverting them caused breakage downstream.
Follow-up to #9993.