Skip to content

[Merged by Bors] - refactor(PartialHomeomorph): Remove explicit variable (x : M).#10083

Closed
grunweg wants to merge 7 commits intomasterfrom
MR-fixup-extchart-lemma
Closed

[Merged by Bors] - refactor(PartialHomeomorph): Remove explicit variable (x : M).#10083
grunweg wants to merge 7 commits intomasterfrom
MR-fixup-extchart-lemma

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 28, 2024

Instead, supply it as needed.

This replaces an explicit argument (x : M) by an implicit {x : M} in the following lemmas:

  • extChartAt_source_mem_nhds'
  • extChartAt_source_mem_nhdsWithin'
  • continuousAt_extChartAt'
  • extChartAt_image_nhd_mem_nhds_of_boundaryless
  • extChartAt_target_mem_nhdsWithin'
  • nhdsWithin_extChartAt_target_eq'
  • continuousAt_extChartAt_symm'
  • continuousAt_extChartAt_symm''
  • map_extChartAt_nhdsWithin_eq_image'
  • map_extChartAt_nhdsWithin'
  • map_extChartAt_symm_nhdsWithin'
  • map_extChartAt_symm_nhdsWithin_range'
  • extChartAt_preimage_mem_nhdsWithin'
  • extChartAt_preimage_mem_nhdsWithin
  • extChartAt_preimage_mem_nhds'
  • extChartAt_preimage_mem_nhds

Open in Gitpod

…daryless

Fixes an oversight in #xxxx: x is already included in a hypothesis, so should be implicit.
Instead, supply it as needed.
This changes map_extChartAt_symm_nhdsWithin'; one unnecessary argument x is dropped.
@winstonyin winstonyin added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jan 29, 2024
@grunweg grunweg force-pushed the MR-fixup-extchart-lemma branch from f11c182 to e9e7ecd Compare January 29, 2024 17:34
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 29, 2024

@winstonyin Thank you for the sharp eye. You were right.

@grunweg grunweg added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jan 29, 2024
@grunweg grunweg force-pushed the MR-fixup-extchart-lemma branch from e9e7ecd to 0b2a608 Compare January 29, 2024 17:38
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 31, 2024
@grunweg grunweg removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 31, 2024
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 1, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Feb 1, 2024
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Feb 1, 2024

Thank you for the review.
bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 1, 2024

Canceled.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Feb 1, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 1, 2024
Instead, supply it as needed.

This replaces an explicit argument (x : M) by an implicit `{x : M}` in the following lemmas:
- extChartAt_source_mem_nhds'
- extChartAt_source_mem_nhdsWithin'
- continuousAt_extChartAt'
- extChartAt_image_nhd_mem_nhds_of_boundaryless
- extChartAt_target_mem_nhdsWithin'
- nhdsWithin_extChartAt_target_eq'
- continuousAt_extChartAt_symm'
- continuousAt_extChartAt_symm''
- map_extChartAt_nhdsWithin_eq_image'
- map_extChartAt_nhdsWithin'
- map_extChartAt_symm_nhdsWithin'
- map_extChartAt_symm_nhdsWithin_range'
- extChartAt_preimage_mem_nhdsWithin'
- extChartAt_preimage_mem_nhdsWithin
- extChartAt_preimage_mem_nhds'
- extChartAt_preimage_mem_nhds



Co-authored-by: grunweg <grunweg@posteo.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(PartialHomeomorph): Remove explicit variable (x : M). [Merged by Bors] - refactor(PartialHomeomorph): Remove explicit variable (x : M). Feb 1, 2024
@mathlib-bors mathlib-bors bot closed this Feb 1, 2024
@mathlib-bors mathlib-bors bot deleted the MR-fixup-extchart-lemma branch February 1, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants