[Merged by Bors] - refactor(PartialHomeomorph): make (s : Opens \alpha) implicit#10082
Closed
[Merged by Bors] - refactor(PartialHomeomorph): make (s : Opens \alpha) implicit#10082
Conversation
…is always used with a hypothesis involving s Follow-up to #....
Contributor
Author
|
@winstonyin I'd be interested in your opinion on this, as you wrote #9894. |
Member
|
The reason why we kept these arguments explicit in Lean 3 was the following: if you have |
Contributor
Author
|
Good point; I did not know that. I asked on zulip. |
4 tasks
Contributor
Author
|
My understanding of the zulip discussion is that keeping the arguments explicit is no longer necessary. I have updated the commit message accordingly and propose that we move forward with this PR. |
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
It is always used in conjunction with a hypothesis `hs` about `s`.
In Lean 3, these arguments were kept explicit on purpose: given a definition `myDef {x : α} (hx : MyProp x)`,
if the proof of `hx` was nontrivial (not a variable), Lean would pretty-print it as `myDef _`.
In Lean 4, setting `pp.proofs.withType` or `pp.proofs` to true makes such terms pretty-print as `myDef (x : MyProp)`.
Hence, this workaround is no longer necessary.
Follow-up to #9894.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
It is always used in conjunction with a hypothesis `hs` about `s`.
In Lean 3, these arguments were kept explicit on purpose: given a definition `myDef {x : α} (hx : MyProp x)`,
if the proof of `hx` was nontrivial (not a variable), Lean would pretty-print it as `myDef _`.
In Lean 4, setting `pp.proofs.withType` or `pp.proofs` to true makes such terms pretty-print as `myDef (x : MyProp)`.
Hence, this workaround is no longer necessary.
Follow-up to #9894.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is always used in conjunction with a hypothesis
hsabouts.In Lean 3, these arguments were kept explicit on purpose: given a definition
myDef {x : α} (hx : MyProp x),if the proof of
hxwas nontrivial (not a variable), Lean would pretty-print it asmyDef _.In Lean 4, setting
pp.proofs.withTypeorpp.proofsto true makes such terms pretty-print asmyDef (x : MyProp).Hence, this workaround is no longer necessary.
Follow-up to #9894.