Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/dfinsupp): add arithmetic lemmas about filter#9175

Closed
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/dfinsupp-filter
Closed

[Merged by Bors] - feat(data/dfinsupp): add arithmetic lemmas about filter#9175
eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser/dfinsupp-filter

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Sep 12, 2021

This adds dfinsupp.filter_{zero,add,neg,sub,smul} and dfinsupp.subtype_domain_smul, along with some bundled maps.

This also cleans up some variable explicitness.


Open in Gitpod

I need filter_add_monoid_hom in order to state a bsupr version of add_submonoid.supr_eq_mrange_dfinsupp_sum_add_hom

Also golf some uses of `quotient.lift_on` to use `quotient.map`.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Sep 12, 2021
@eric-wieser eric-wieser force-pushed the eric-wieser/dfinsupp-filter branch from f530939 to 4c3d262 Compare September 13, 2021 08:53
Copy link
Copy Markdown
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 16, 2021
bors bot pushed a commit that referenced this pull request Sep 16, 2021
This adds `dfinsupp.filter_{zero,add,neg,sub,smul}` and `dfinsupp.subtype_domain_smul`, along with some bundled maps.

This also cleans up some variable explicitness.
@bors
Copy link
Copy Markdown

bors bot commented Sep 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/dfinsupp): add arithmetic lemmas about filter [Merged by Bors] - feat(data/dfinsupp): add arithmetic lemmas about filter Sep 16, 2021
@bors bors bot closed this Sep 16, 2021
@bors bors bot deleted the eric-wieser/dfinsupp-filter branch September 16, 2021 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants