feat(order/filter/filter_product): build hyperreals#801
Conversation
|
Comments on the form:
Otherwise, the maths look good (except that you are missing a field instance when your filter is a ultrafilter). |
23f80f4 to
6bbe86a
Compare
johoelzl
left a comment
There was a problem hiding this comment.
Hi @abhimanyupallavisudhir,
the formalization looks really nice. I have a couple of style comments and requests for changes.
Construction of filter products, ultraproducts, some instances, hyperreal numbers.
|
@abhimanyupallavisudhir I already made the fix and checked compilation on my machine. I am just waiting for the Travis check to finish, and then I'll merge. |
Isn't making |
|
@abhimanyupallavisudhir I didn't even see your change. I think we pushed them at the same time. Could you make the argument implicit again and adapt @jcommelin's suggestions as you see fit? Then I'll merge right away. |
|
Ok, all done. |
…nity#801) Construction of filter products, ultraproducts, some instances, hyperreal numbers.
Construction of "filter products" (ultraproducts on a general filter), ultraproducts, some instances, hyperreal numbers. Not sure if it belongs in another folder.