Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

feat(*): has_mem (set α) (filter α)#799

Merged
johoelzl merged 1 commit intomasterfrom
has_mem_filter
Mar 8, 2019
Merged

feat(*): has_mem (set α) (filter α)#799
johoelzl merged 1 commit intomasterfrom
has_mem_filter

Conversation

@PatrickMassot
Copy link
Copy Markdown
Member

This is the long overdue instance has_mem (set α) (filter α). It gets rid of countless .sets and parentheses, and make every filter use closer to the real world thing. There are still a couple of inconveniences: of course we still have a couple of lemmas about the sets of a filter, and rewriting using them is not always possible, even though the instance is reducible. The workaround is to add a couple of show or change, or type ascriptions when using the funny triangle. I also added mem_infi to replace many uses of infi_sets_eq.

A weirder thing is in asymptotics.lean where use times out. I replaced those bby refine and everything works smoothly.

@PatrickMassot PatrickMassot requested a review from johoelzl March 7, 2019 18:01
Copy link
Copy Markdown
Collaborator

@johoelzl johoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@johoelzl johoelzl merged commit ffa6d69 into master Mar 8, 2019
@johoelzl johoelzl deleted the has_mem_filter branch March 8, 2019 07:47
@PatrickMassot
Copy link
Copy Markdown
Member Author

Thanks @johoelzl for merging this quickly!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants