Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - refactor(group_theory/group_action/defs): generalize smul_mul_assoc and mul_smul_comm#7441

Closed
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/mul_smul_assoc
Closed

[Merged by Bors] - refactor(group_theory/group_action/defs): generalize smul_mul_assoc and mul_smul_comm#7441
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/mul_smul_assoc

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

These lemmas did not need a full algebra structure; written this way, it permits usage on has_scalar (units R) A given algebra R A (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.


Open in Gitpod

This lemma did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.
Copy link
Copy Markdown
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 4, 2021
bors bot pushed a commit that referenced this pull request May 4, 2021
…nd mul_smul_comm (#7441)

These lemmas did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.
@bors
Copy link
Copy Markdown

bors bot commented May 4, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 4, 2021
…nd mul_smul_comm (#7441)

These lemmas did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.
@bors
Copy link
Copy Markdown

bors bot commented May 4, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 5, 2021
…nd mul_smul_comm (#7441)

These lemmas did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.
@bors
Copy link
Copy Markdown

bors bot commented May 5, 2021

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 5, 2021
…nd mul_smul_comm (#7441)

These lemmas did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.
@bors
Copy link
Copy Markdown

bors bot commented May 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(group_theory/group_action/defs): generalize smul_mul_assoc and mul_smul_comm [Merged by Bors] - refactor(group_theory/group_action/defs): generalize smul_mul_assoc and mul_smul_comm May 5, 2021
@bors bors bot closed this May 5, 2021
@bors bors bot deleted the eric-wieser/mul_smul_assoc branch May 5, 2021 23:47
Vierkantor pushed a commit that referenced this pull request May 6, 2021
…nd mul_smul_comm (#7441)

These lemmas did not need a full algebra structure; written this way, it permits usage on `has_scalar (units R) A` given `algebra R A` (in some future PR).

For now, the old algebra lemmas are left behind, to minimize the scope of this patch.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants