This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(algebra/*): add back nat_algebra_subsingleton and add_comm_monoid.nat_semimodule.subsingleton#7263
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
Conversation
…id.nat_semimodule.subsingleton
Collaborator
|
I have already added them back in #7255 as was requested. |
Member
Author
|
You haven't added back the |
Member
Author
|
I've updated to use the comments and lemma names from that PR, but was able to produce a shorter proof |
Collaborator
|
Nice, thanks! |
|
Merge conflict. |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2021
…id.nat_semimodule.subsingleton (#7263) As suggested in #7084 (comment). Even if we now have a design solution that makes this unnecessary, it still feels like a result worth stating.
|
Pull request successfully merged into master. Build succeeded: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #7084 (comment).
Even if we now have a design solution that makes this unnecessary, it still feels like a result worth stating.