This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Conversation
eric-wieser
reviewed
Apr 18, 2021
eric-wieser
reviewed
Apr 18, 2021
1 task
kim-em
approved these changes
Apr 19, 2021
Collaborator
kim-em
left a comment
There was a problem hiding this comment.
LGTM to me. Thanks so much for resolving these slow proofs!
jcommelin
reviewed
Apr 19, 2021
| add_comm := by {intros, ext, unfold coe_fn has_coe_to_fun.coe sesq, rw add_comm} } | ||
| sesq_smul_right := λ a x y, by rw [sesq_smul_right, mul_neg_eq_neg_mul_symm] }⟩ | ||
|
|
||
| instance : add_comm_group (sesq_form R M I) := |
Member
There was a problem hiding this comment.
Shouldn't this get a dedicated nsmul field now?
Collaborator
Author
There was a problem hiding this comment.
They get one for free, which is the naive one defined by induction. One should only add one by hand if there is a risk of diamond, i.e., if we ever consider sesquilinear forms over naturals or integers. Sesquilinear forms over naturals don't make sense, so there is no issue here. There is an issue over the integers, so we should probably add a gsmul field, yes. I'll do it in #7255.
Member
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2021
Proofs that are too slow for the forthcoming `gsmul` refactor. I learnt that `by convert ...` is extremely useful even to close a goal, when elaboration using the expected type is a bad idea.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proofs that are too slow for the forthcoming
gsmulrefactor. I learnt thatby convert ...is extremely useful even to close a goal, when elaboration using the expected type is a bad idea.