This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/indicator_function): add multiplicative version#6794
Closed
[Merged by Bors] - feat(data/indicator_function): add multiplicative version#6794
Conversation
This will help us add `finprod` in #6355
Closed
2 tasks
eric-wieser
approved these changes
Mar 22, 2021
Member
eric-wieser
left a comment
There was a problem hiding this comment.
I've only skimmed this, but the idea looks good to me, and I'm reasonably confident in CI's ability to catch mistakes!
kbuzzard
reviewed
Mar 22, 2021
Member
kbuzzard
left a comment
There was a problem hiding this comment.
Thank you so much for this rather large refactor.
| | is_comm ("le" :: "one" :: s) := add_comm_prefix is_comm "nonpos" :: tr ff s | ||
| | is_comm ("lt" :: "one" :: s) := add_comm_prefix is_comm "neg" :: tr ff s | ||
| | is_comm ("mul" :: "support" :: s) := add_comm_prefix is_comm "support" :: tr ff s | ||
| | is_comm ("mul" :: "indicator" :: s) := add_comm_prefix is_comm "indicator" :: tr ff s |
Member
There was a problem hiding this comment.
Do we now want to normalising the spacing again? The next few lines now look a bit weird.
Member
Author
There was a problem hiding this comment.
I did this in the fincard branch. I'll cherry-pick this chunk tonight.
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Member
Author
|
bors r- |
Member
Author
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need it for
finprodfunction.mul_support#6791