Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - chore(algebra/ordered_ring): remove duplicate lemma#4295

Closed
kim-em wants to merge 2 commits intomasterfrom
two_pos
Closed

[Merged by Bors] - chore(algebra/ordered_ring): remove duplicate lemma#4295
kim-em wants to merge 2 commits intomasterfrom
two_pos

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Sep 28, 2020

ordered_ring.two_pos and ordered_ring.zero_lt_two had ended up identical. I kept zero_lt_two.


Copy link
Copy Markdown
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 28, 2020
bors bot pushed a commit that referenced this pull request Sep 28, 2020
`ordered_ring.two_pos` and `ordered_ring.zero_lt_two` had ended up identical. I kept `zero_lt_two`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Sep 28, 2020

Build failed:

@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Sep 28, 2020

I'll try again.

bors merge

bors bot pushed a commit that referenced this pull request Sep 28, 2020
`ordered_ring.two_pos` and `ordered_ring.zero_lt_two` had ended up identical. I kept `zero_lt_two`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Sep 28, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/ordered_ring): remove duplicate lemma [Merged by Bors] - chore(algebra/ordered_ring): remove duplicate lemma Sep 28, 2020
@bors bors bot closed this Sep 28, 2020
@bors bors bot deleted the two_pos branch September 28, 2020 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants