Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(order/filter/lift): a few lemmas about filter.lift' _ powerset#3652

Closed
urkud wants to merge 3 commits intomasterfrom
lift-powerset
Closed

[Merged by Bors] - feat(order/filter/lift): a few lemmas about filter.lift' _ powerset#3652
urkud wants to merge 3 commits intomasterfrom
lift-powerset

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Aug 1, 2020


filter_eq $ set.ext $ by simp only [mem_lift'_sets, monotone_preimage, comap, exists_prop, forall_const, iff_self, mem_set_of_eq]
filter.ext $ λ s, (mem_lift'_sets monotone_preimage).symm

lemma eventually_lift'_powerset {f : filter α} {p : set α → Prop} :
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma eventually_lift'_powerset {f : filter α} {p : set α → Prop} :
@[simp] lemma eventually_lift'_powerset {f : filter α} {p : set α → Prop} :

? And possibly below. But I'm not really sure.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two @[simp] attributes but not here: I don't want to simp from eventually to ∃ s ∈ f by default.

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 1, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 1, 2020
@robertylewis
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 2, 2020
@bors
Copy link
Copy Markdown

bors bot commented Aug 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/filter/lift): a few lemmas about filter.lift' _ powerset [Merged by Bors] - feat(order/filter/lift): a few lemmas about filter.lift' _ powerset Aug 2, 2020
@bors bors bot closed this Aug 2, 2020
@bors bors bot deleted the lift-powerset branch August 2, 2020 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants