This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/matrix): matrix and vector notation#2656
Closed
Vierkantor wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - feat(data/matrix): matrix and vector notation#2656Vierkantor wants to merge 5 commits intomasterfrom
Vierkantor wants to merge 5 commits intomasterfrom
Conversation
Member
|
Why is there still boilerplate in the PR description? I thought that we've removed it already? In any case, please remove the part after and including "Make sure you have" as this would be included in the commit message. |
Collaborator
Author
Ah, my bad! I thought GitHub was having issues (the interactive buttons didn't work), so I copied the old template manually. |
jcommelin
reviewed
May 11, 2020
Member
jcommelin
left a comment
There was a problem hiding this comment.
Nice work! Thanks 🎉
Looks pretty good to me.
Co-authored-by: Johan Commelin <johan@commelin.net>
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 12, 2020
This PR adds notation for matrices and vectors [as discussed on Zulip a couple of months ago](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Notation.20for.20matrices.20and.20vectors), so that `![![a, b], ![c, d]]` constructs a 2x2 matrix with rows `![a, b] : fin 2 -> α` and `![c, d]`. It also adds corresponding `simp` lemmas for all matrix operations defined in `data.matrix.basic`. These lemmas should apply only when the input already contains `![...]`. To express the `simp` lemmas nicely, I defined a function `dot_product : (v w : n -> α) -> α` which returns the sum of the entrywise product of two vectors. IMO, this makes the definitions of `matrix.mul`, `matrix.mul_vec` and `matrix.vec_mul` clearer, and it allows us to share some proofs. I could also inline `dot_product` (restoring the old situation) if the reviewers prefer. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com> Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
Collaborator
|
It's too late for this PR, but it looks like something goes wrong in the |
Member
|
What could possibly go wrong if you name a file |
butterthebuddha
pushed a commit
to butterthebuddha/mathlib
that referenced
this pull request
May 15, 2020
) This PR adds notation for matrices and vectors [as discussed on Zulip a couple of months ago](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Notation.20for.20matrices.20and.20vectors), so that `![![a, b], ![c, d]]` constructs a 2x2 matrix with rows `![a, b] : fin 2 -> α` and `![c, d]`. It also adds corresponding `simp` lemmas for all matrix operations defined in `data.matrix.basic`. These lemmas should apply only when the input already contains `![...]`. To express the `simp` lemmas nicely, I defined a function `dot_product : (v w : n -> α) -> α` which returns the sum of the entrywise product of two vectors. IMO, this makes the definitions of `matrix.mul`, `matrix.mul_vec` and `matrix.vec_mul` clearer, and it allows us to share some proofs. I could also inline `dot_product` (restoring the old situation) if the reviewers prefer. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com> Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
butterthebuddha
pushed a commit
to butterthebuddha/mathlib
that referenced
this pull request
May 16, 2020
) This PR adds notation for matrices and vectors [as discussed on Zulip a couple of months ago](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Notation.20for.20matrices.20and.20vectors), so that `![![a, b], ![c, d]]` constructs a 2x2 matrix with rows `![a, b] : fin 2 -> α` and `![c, d]`. It also adds corresponding `simp` lemmas for all matrix operations defined in `data.matrix.basic`. These lemmas should apply only when the input already contains `![...]`. To express the `simp` lemmas nicely, I defined a function `dot_product : (v w : n -> α) -> α` which returns the sum of the entrywise product of two vectors. IMO, this makes the definitions of `matrix.mul`, `matrix.mul_vec` and `matrix.vec_mul` clearer, and it allows us to share some proofs. I could also inline `dot_product` (restoring the old situation) if the reviewers prefer. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com> Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
) This PR adds notation for matrices and vectors [as discussed on Zulip a couple of months ago](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Notation.20for.20matrices.20and.20vectors), so that `![![a, b], ![c, d]]` constructs a 2x2 matrix with rows `![a, b] : fin 2 -> α` and `![c, d]`. It also adds corresponding `simp` lemmas for all matrix operations defined in `data.matrix.basic`. These lemmas should apply only when the input already contains `![...]`. To express the `simp` lemmas nicely, I defined a function `dot_product : (v w : n -> α) -> α` which returns the sum of the entrywise product of two vectors. IMO, this makes the definitions of `matrix.mul`, `matrix.mul_vec` and `matrix.vec_mul` clearer, and it allows us to share some proofs. I could also inline `dot_product` (restoring the old situation) if the reviewers prefer. Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com> Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds notation for matrices and vectors as discussed on Zulip a couple of months ago, so that
![![a, b], ![c, d]]constructs a 2x2 matrix with rows![a, b] : fin 2 -> αand![c, d]. It also adds correspondingsimplemmas for all matrix operations defined indata.matrix.basic. These lemmas should apply only when the input already contains![...].To express the
simplemmas nicely, I defined a functiondot_product : (v w : n -> α) -> αwhich returns the sum of the entrywise product of two vectors. IMO, this makes the definitions ofmatrix.mul,matrix.mul_vecandmatrix.vec_mulclearer, and it allows us to share some proofs. I could also inlinedot_product(restoring the old situation) if the reviewers prefer.