This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/multiset/pi): correct names and reorder#19050
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore(data/multiset/pi): correct names and reorder#19050eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser wants to merge 1 commit intomasterfrom
Conversation
`multiset.pi_cons_injective` is about `multiset.pi.cons` so should have a `.` in its name. This also groups together the lemmas about `pi.cons`.
25f4c9f to
a110446
Compare
This was referenced May 19, 2023
YaelDillies
reviewed
May 21, 2023
| end | ||
|
|
||
| lemma pi.cons_injective {a : α} {b : δ a} {s : multiset α} (hs : a ∉ s) : | ||
| function.injective (pi.cons s a b) := |
Collaborator
There was a problem hiding this comment.
Suggested change
| function.injective (pi.cons s a b) := | |
| injective (pi.cons s a b) := |
function is already open, I believe.
Member
Author
There was a problem hiding this comment.
Given I just moved these lines and I've already done the forward-port, I'm inclined to leave it as is
Collaborator
There was a problem hiding this comment.
Fine, I guess that doesn't matter much.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 21, 2023
* `multiset.pi_cons_injective` is about `multiset.pi.cons` so should have a `.` in its name. * `multiset.pi.cons_ext` is not an ext lemma, but more closely resembles eta-reduction. This also groups together the lemmas about `pi.cons`.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiset.pi_cons_injectiveis aboutmultiset.pi.consso should have a.in its name.multiset.pi.cons_extis not an ext lemma, but more closely resembles eta-reduction.This also groups together the lemmas about
pi.cons.The purpose of this PR is to split #18417 in half so that it's easier to cut out the style noise from that PR (which is an impediment to forward-porting)