This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(analysis/inner_product_space/basic): golf, add/merge lemmas#18928
Closed
[Merged by Bors] - chore(analysis/inner_product_space/basic): golf, add/merge lemmas#18928
Conversation
- Merge `inner_product_space.of_core.inner_self_nonneg_im` and `inner_product_space.of_core.inner_self_im_zero` into `inner_product_space.of_core.inner_self_im`. - Add `inner_product_space.of_core.norm_sq_eq_zero`. - Merge `inner_self_nonneg_im` and `inner_self_im_zero` into `inner_self_im`.
4 tasks
eric-wieser
reviewed
May 3, 2023
Member
There was a problem hiding this comment.
Nice catch on the bad names here, though I don't see a mention of this in the PR description. Can you either mention it, or split this change to a new PR?
Member
Author
There was a problem hiding this comment.
This is a part of another PR. I merged staging branch, so it is temporarily visible here.
eric-wieser
approved these changes
May 3, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Please wait for the dependent PR to go through (and merge the resulting master) before merging
bors d+
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
|
This PR/issue depends on: |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 3, 2023
…8928) - Merge `inner_product_space.of_core.inner_self_nonneg_im` and `inner_product_space.of_core.inner_self_im_zero` into `inner_product_space.of_core.inner_self_im`. - Rename `inner_product_space.of_core.inner_abs_conj_symm` to `inner_product_space.of_core.abs_inner_symm`. - Rename `inner_abs_conj_symm` to `abs_inner_symm`. - Add `inner_product_space.of_core.norm_sq_eq_zero`. - Merge `inner_self_nonneg_im` and `inner_self_im_zero` into `inner_self_im`. - Reorder, golf.
|
Build failed: |
eric-wieser
reviewed
May 3, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 3, 2023
…8928) - Merge `inner_product_space.of_core.inner_self_nonneg_im` and `inner_product_space.of_core.inner_self_im_zero` into `inner_product_space.of_core.inner_self_im`. - Rename `inner_product_space.of_core.inner_abs_conj_symm` to `inner_product_space.of_core.abs_inner_symm`. - Rename `inner_abs_conj_symm` to `abs_inner_symm`. - Add `inner_product_space.of_core.norm_sq_eq_zero`. - Merge `inner_self_nonneg_im` and `inner_self_im_zero` into `inner_self_im`. - Reorder, golf.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inner_product_space.of_core.inner_self_nonneg_imandinner_product_space.of_core.inner_self_im_zerointoinner_product_space.of_core.inner_self_im.inner_product_space.of_core.inner_abs_conj_symmtoinner_product_space.of_core.abs_inner_symm.inner_abs_conj_symmtoabs_inner_symm.inner_product_space.of_core.norm_sq_eq_zero.inner_self_nonneg_imandinner_self_im_zerointoinner_self_im.abs_norm_eq_normtoabs_norm#18921