Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(topology/sets/compacts): add positive_compacts.map#18872

Closed
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/compacts-map
Closed

[Merged by Bors] - feat(topology/sets/compacts): add positive_compacts.map#18872
eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser/compacts-map

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Apr 26, 2023

Also adds some missing functorial lemmas about map.


Open in Gitpod

I expect to be able to use this in a future PR to golf basis.parallelepiped, though I think having basic functorial definitions is worthwhile in general.

Also adds some missing functorial lemmas about `map`
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 26, 2023
@eric-wieser eric-wieser requested a review from fpvandoorn April 26, 2023 09:03
@github-actions github-actions bot added modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 26, 2023
@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 11, 2023
bors bot pushed a commit that referenced this pull request May 11, 2023
Also adds some missing functorial lemmas about `map`.
@bors
Copy link
Copy Markdown

bors bot commented May 11, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(topology/sets/compacts): add positive_compacts.map [Merged by Bors] - feat(topology/sets/compacts): add positive_compacts.map May 11, 2023
@bors bors bot closed this May 11, 2023
@bors bors bot deleted the eric-wieser/compacts-map branch May 11, 2023 23:16
eric-wieser added a commit to leanprover-community/mathlib4 that referenced this pull request May 13, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants