This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(category_theory/monad/basic): remove some simp lemmas#18727
Closed
[Merged by Bors] - chore(category_theory/monad/basic): remove some simp lemmas#18727
Conversation
Member
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
This is a backport from mathlib4, where the simpNF (correctly) linter disapproves of these lemmas. Mostly this PR exists to verify that these are not needed in the simp set. leanprover-community/mathlib4#2969 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 6, 2023
The [porting PR](#2969) removed two `@[simp]` that the simpNF linter complained about. Now that I've verified they are not actually needed downstream (see leanprover-community/mathlib3#18727), we may as well remove the comments. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 6, 2023
The [porting PR](#2969) removed two `@[simp]` that the simpNF linter complained about. Now that I've verified they are not actually needed downstream (see leanprover-community/mathlib3#18727), we may as well remove the comments. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 6, 2023
The [porting PR](#2969) removed two `@[simp]` that the simpNF linter complained about. Now that I've verified they are not actually needed downstream (see leanprover-community/mathlib3#18727), we may as well remove the comments. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 6, 2023
The [porting PR](#2969) removed two `@[simp]` that the simpNF linter complained about. Now that I've verified they are not actually needed downstream (see leanprover-community/mathlib3#18727), we may as well remove the comments. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
MonadMaverick
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 9, 2023
The [porting PR](#2969) removed two `@[simp]` that the simpNF linter complained about. Now that I've verified they are not actually needed downstream (see leanprover-community/mathlib3#18727), we may as well remove the comments. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
MonadMaverick
pushed a commit
to MonadMaverick/mathlib4
that referenced
this pull request
Apr 9, 2023
The [porting PR](leanprover-community#2969) removed two `@[simp]` that the simpNF linter complained about. Now that I've verified they are not actually needed downstream (see leanprover-community/mathlib3#18727), we may as well remove the comments. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
xroblot
pushed a commit
that referenced
this pull request
Apr 23, 2023
This is a backport from mathlib4, where the simpNF (correctly) linter disapproves of these lemmas. Mostly this PR exists to verify that these are not needed in the simp set. leanprover-community/mathlib4#2969 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport from mathlib4, where the simpNF (correctly) linter disapproves of these lemmas. Mostly this PR exists to verify that these are not needed in the simp set.
leanprover-community/mathlib4#2969