Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - chore(*): Miscellaneous lemmas#18677

Closed
YaelDillies wants to merge 7 commits intomasterfrom
set_of_inter
Closed

[Merged by Bors] - chore(*): Miscellaneous lemmas#18677
YaelDillies wants to merge 7 commits intomasterfrom
set_of_inter

Conversation

@YaelDillies
Copy link
Copy Markdown
Collaborator

@YaelDillies YaelDillies commented Mar 27, 2023

  • algebra.support: support n = univ if n ≠ 0, mul_support n = univ if n ≠ 1
  • data.int.char_zero: ↑n = 1 ↔ n = 1
  • data.real.ennreal: of_real a.to_real = a ↔ a ≠ ⊤, (of_real a).to_real = a ↔ 0 ≤ a
  • data.set.basic: s ∩ {a | p a} = {a ∈ s | p a}
  • logic.function.basic: on_fun f g a b = f (g a) (g b)
  • order.conditionally_complete_lattice.basic: Lemmas unfolding the definition of Sup/Inf on with_top/with_bot

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Mar 27, 2023
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I think this should probably just be titled chore(*): miscellaneous lemmas, and then just add 5 or so bullet points in the description summarize the themes (probably one per file)

@bors
Copy link
Copy Markdown

bors bot commented Mar 31, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 31, 2023
@YaelDillies YaelDillies changed the title feat(data/set/basic): {a | p a} ∩ s = {a ∈ s | p a} chore(*): Miscellaneous lemmas Mar 31, 2023
@YaelDillies
Copy link
Copy Markdown
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 31, 2023
* `algebra.support`: `support n = univ` if `n ≠ 0`, `mul_support n = univ` if `n ≠ 1`
* `data.int.char_zero`: `↑n = 1 ↔ n = 1`
* `data.real.ennreal`: `of_real a.to_real = a ↔ a ≠ ⊤`, `(of_real a).to_real = a ↔ 0 ≤ a`
* `data.set.basic`: `s ∩ {a | p a} = {a ∈ s | p a}`
* `logic.function.basic`: `on_fun f g a b = f (g a) (g b)`
* `order.conditionally_complete_lattice.basic`: Lemmas unfolding the definition of `Sup`/`Inf` on `with_top`/`with_bot`
@bors
Copy link
Copy Markdown

bors bot commented Mar 31, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): Miscellaneous lemmas [Merged by Bors] - chore(*): Miscellaneous lemmas Mar 31, 2023
@bors bors bot closed this Mar 31, 2023
@bors bors bot deleted the set_of_inter branch March 31, 2023 17:47
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 1, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 1, 2023
MonadMaverick pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 9, 2023
MonadMaverick pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants