This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(algebra/algebra/basic): missing lemmas about the ↑ spelling of algebra_map#18422
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore(algebra/algebra/basic): missing lemmas about the ↑ spelling of algebra_map#18422eric-wieser wants to merge 2 commits intomasterfrom
↑ spelling of algebra_map#18422eric-wieser wants to merge 2 commits intomasterfrom
Conversation
…f `algebra_map` This only really scratches the surface; in general we can't afford to have two different spellings here as it forces us to duplicate every result about `ring_hom`. A previously refactor (#17048) made these lemmas unecessary, but it was reverted to aid with the port. Since these lemmas are needed in mathlib3 PRs, lets have them anyway.
Collaborator
|
Linter's not happy it seems |
Member
|
Thanks! 🎉 |
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
…f `algebra_map` (#18422) This only really scratches the surface; in general we can't afford to have two different spellings here as it forces us to duplicate every result about `ring_hom`. A previously refactor (#17048) made these lemmas unecessary, but it was reverted to aid with the port. Since these lemmas are needed in mathlib3 PRs, lets have them anyway. For consistency with the existing `algebra_map.coe_mul` etc, these are not `simp` lemmas. Making them `simp` lemmas makes a bunch of downstream `simp` lemmas redundant; so perhaps worth exploring in a future PR.
|
Pull request successfully merged into master. Build succeeded: |
↑ spelling of algebra_map↑ spelling of algebra_map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only really scratches the surface; in general we can't afford to have two different spellings here as it forces us to duplicate every result about
ring_hom. A previously refactor (#17048) made these lemmas unecessary, but it was reverted to aid with the port. Since these lemmas are needed in mathlib3 PRs, lets have them anyway.For consistency with the existing
algebra_map.coe_muletc, these are notsimplemmas.Making them
simplemmas makes a bunch of downstreamsimplemmas redundant; so perhaps worth exploring in a future PR.