This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - refactor(data/fintype/basic): move fin_choice to a new file#18337
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - refactor(data/fintype/basic): move fin_choice to a new file#18337eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser wants to merge 1 commit intomasterfrom
Conversation
This was referenced Jan 31, 2023
Collaborator
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 1, 2023
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
There is a refactor in the works for these definitions; it will be easier to review and port the refactor if we move this all to a new file first and just forward-port the deletion.
|
Pull request successfully merged into master. Build succeeded: |
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 1, 2023
This forward-ports: * leanprover-community/mathlib3#18277. No action is needed as the proof was already fixed during porting. * leanprover-community/mathlib3#18337. This was forward-ported in #1970 but the SHA was not updated. See the diff here: * [`data.fintype.basic`@`9003f28797c0664a49e4179487267c494477d853`..`d78597269638367c3863d40d45108f52207e03cf`](https://leanprover-community.github.io/mathlib-port-status/file/data/fintype/basic?range=9003f28797c0664a49e4179487267c494477d853..d78597269638367c3863d40d45108f52207e03cf)
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 5, 2023
This forward-ports: * leanprover-community/mathlib3#18277. No action is needed as the proof was already fixed during porting. * leanprover-community/mathlib3#18337. This was forward-ported in #1970 but the SHA was not updated. See the diff here: * [`data.fintype.basic`@`9003f28797c0664a49e4179487267c494477d853`..`d78597269638367c3863d40d45108f52207e03cf`](https://leanprover-community.github.io/mathlib-port-status/file/data/fintype/basic?range=9003f28797c0664a49e4179487267c494477d853..d78597269638367c3863d40d45108f52207e03cf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a refactor in the works for these definitions; it will be easier to review and port the refactor if we move this all to a new file first and just forward-port the deletion.
The copyright is from ddbb813
Paired with leanprover-community/mathlib4#1970