This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/quot): make trunc a quotient#18320
Closed
astrainfinita wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat(data/quot): make trunc a quotient#18320astrainfinita wants to merge 4 commits intomasterfrom
trunc a quotient#18320astrainfinita wants to merge 4 commits intomasterfrom
Conversation
This allows us to use `quotient` lemmas for `trunc`.
2 tasks
trunc a quotienttrunc a quotient
Member
|
bors merge |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 31, 2023
mathlib3 PR: leanprover-community/mathlib3#18320
bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
This allows us to use `quotient` lemmas for `trunc`. mathlib4 PR: leanprover-community/mathlib4#1924
eric-wieser
reviewed
Jan 31, 2023
src/data/quot.lean
Outdated
Comment on lines
+371
to
+373
| /-- Always-true relation as a `setoid`. -/ | ||
| def true_setoid : setoid α := | ||
| ⟨_, true_equivalence⟩ |
Member
There was a problem hiding this comment.
This already exists, it's ⊤ : setoid α.
Member
There was a problem hiding this comment.
Since this fell off the bors batch, I pushed a comment remarking that ⊤ : setoid α is another spelling of the same thing.
|
Build failed (retrying...): |
Member
|
bors merge |
eric-wieser
reviewed
Jan 31, 2023
|
Canceled. |
eric-wieser
reviewed
Jan 31, 2023
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
This allows us to use `quotient` lemmas for `trunc`. mathlib4 PR: leanprover-community/mathlib4#1924 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
trunc a quotienttrunc a quotient
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 3, 2023
This forward-ports the last commits in leanprover-community/mathlib3#18320, which was prematurely forward-ported as #1924 before it was merged in mathlib3.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 18, 2023
leanprover-community/mathlib3#18320 was already forward-ported in #1924.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 18, 2023
leanprover-community/mathlib3#18320 was already forward-ported in #1924.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to use
quotientlemmas fortrunc.mathlib4 PR: leanprover-community/mathlib4#1924