This repository was archived by the owner on Jul 24, 2024. It is now read-only.
feat(data/dfinsupp/basic): make sigma_curry computable#18316
Closed
astrainfinita wants to merge 4 commits intomasterfrom
Closed
feat(data/dfinsupp/basic): make sigma_curry computable#18316astrainfinita wants to merge 4 commits intomasterfrom
sigma_curry computable#18316astrainfinita wants to merge 4 commits intomasterfrom
Conversation
Member
|
This file is almost ported. I don't think it's a good idea to change this file now. |
Collaborator
Author
|
Then I'll make a mathlib4 PR later. |
2 tasks
Collaborator
|
I would like to gently push back on this kind of PR. I find it hard to believe this change has any practical benefit, that would justify the time it would take to review the corresponding mathlib 4 change. |
Collaborator
Author
|
I'm not in a hurry to merge it, so I think it's OK. Can we have a mathlib4 PR label like "awaiting-port"? |
Collaborator
Author
|
Now there is that label so I'll close this PR. |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 10, 2023
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 14, 2023
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should NOT get merged with #18318 at the same time.
mathlib4 PR: leanprover-community/mathlib4#1947