This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(set_theory/zfc/basic): tweak Class hom lemmas#18295
Closed
[Merged by Bors] - feat(set_theory/zfc/basic): tweak Class hom lemmas#18295
Conversation
2 tasks
1 task
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
This PR/issue depends on:
|
YaelDillies
approved these changes
Feb 26, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
The rest looks good.
YaelDillies
reviewed
Feb 28, 2023
YaelDillies
reviewed
Feb 28, 2023
Collaborator
Author
|
I've renamed the |
YaelDillies
reviewed
Mar 1, 2023
YaelDillies
reviewed
Mar 1, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks, it looks good now!
Collaborator
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
eric-wieser
approved these changes
Mar 26, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors merge
Thanks! Again, this will probably need a forward-port.
bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
This PR renames a bunch of `hom` lemmas to better match the style of the rest of mathlib, and tags them as `norm_cast`. We also add the corresponding lemmas for the union. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
This PR renames a bunch of `hom` lemmas to better match the style of the rest of mathlib, and tags them as `norm_cast`. We also add the corresponding lemmas for the union. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
This PR renames a bunch of `hom` lemmas to better match the style of the rest of mathlib, and tags them as `norm_cast`. We also add the corresponding lemmas for the union. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed: |
Collaborator
|
There was a slight conflict with another PR. All fixed now. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Collaborator
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
This PR renames a bunch of `hom` lemmas to better match the style of the rest of mathlib, and tags them as `norm_cast`. We also add the corresponding lemmas for the union. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames a bunch of
homlemmas to better match the style of the rest of mathlib, and tags them asnorm_cast. We also add the corresponding lemmas for the union.