This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - refactor(data/set/finite): reduce imports#18245
Closed
[Merged by Bors] - refactor(data/set/finite): reduce imports#18245
Conversation
eric-wieser
reviewed
Jan 20, 2023
YaelDillies
approved these changes
Jan 22, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks 🎉
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
Author
|
Note that |
Collaborator
|
I know, but I still don't have But also note that it's acceptable to merge this PR now that you've opened a matching one, even if the matching one was not approved. |
Collaborator
|
bors d+ |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 22, 2023
* Add `eq_or_eq_or_eq_of_forall_not_lt_lt`, `finite.of_forall_not_lt_lt`, `set.finite_of_forall_not_lt_lt` (replacing `set.finite_of_forall_between_eq_endpoints`), and `set.finite_of_forall_not_lt_lt'`. * Import `data.finset.basic` instead of `data.finset.sort` in `data.set.finite`. * Forward-ported in leanprover-community/mathlib4#1738
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 25, 2023
Partial forward-port of leanprover-community/mathlib3#18245
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 25, 2023
Partial forward-port of leanprover-community/mathlib3#18245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eq_or_eq_or_eq_of_forall_not_lt_lt,finite.of_forall_not_lt_lt,set.finite_of_forall_not_lt_lt(replacingset.finite_of_forall_between_eq_endpoints), andset.finite_of_forall_not_lt_lt'.data.finset.basicinstead ofdata.finset.sortindata.set.finite.