Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - refactor(analysis/normed/group/hom): split#18219

Closed
hrmacbeth wants to merge 3 commits intomasterfrom
hrmacbeth-split-normed-group-hom
Closed

[Merged by Bors] - refactor(analysis/normed/group/hom): split#18219
hrmacbeth wants to merge 3 commits intomasterfrom
hrmacbeth-split-normed-group-hom

Conversation

@hrmacbeth
Copy link
Copy Markdown
Member

@hrmacbeth hrmacbeth commented Jan 19, 2023

Half of this file is completely elementary, able to be proved directly from the definitions in normed/group/hom/basic after a few instances are added there. The other half consists of technical lemmas from LTE, never used elsewhere in mathlib, and requires more imports. Since this file is imported by many files (including data/complex/is_R_or_C, see #18217 for a discussion of what that file imports), I propose splitting off the LTE half.


Open in Gitpod

@hrmacbeth hrmacbeth added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Jan 19, 2023
@sgouezel
Copy link
Copy Markdown
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 19, 2023
bors bot pushed a commit that referenced this pull request Jan 19, 2023
Half of this file is completely elementary, able to be proved directly from the definitions in `normed/group/hom/basic` after a few instances are added there.  The other half consists of technical lemmas from LTE, never used elsewhere in mathlib, and requires more imports.  Since this file is imported by many files (including `data/complex/is_R_or_C`, see #18217 for a discussion of what that file imports), I propose splitting off the LTE half.
@bors
Copy link
Copy Markdown

bors bot commented Jan 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(analysis/normed/group/hom): split [Merged by Bors] - refactor(analysis/normed/group/hom): split Jan 19, 2023
@bors bors bot closed this Jan 19, 2023
@bors bors bot deleted the hrmacbeth-split-normed-group-hom branch January 19, 2023 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants