Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - refactor(*): define list.replicate and migrate to it#18127

Closed
urkud wants to merge 17 commits intomasterfrom
YK-list-repeat
Closed

[Merged by Bors] - refactor(*): define list.replicate and migrate to it#18127
urkud wants to merge 17 commits intomasterfrom
YK-list-repeat

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jan 11, 2023

This definition differs from list.repeat by the order of arguments. The new order is in sync with the Lean 4 version.


Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Jan 11, 2023
@urkud urkud requested review from a team as code owners January 11, 2023 03:07
@ghost ghost added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 11, 2023
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 14, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jan 14, 2023

This PR/issue depends on:

@YaelDillies YaelDillies added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 14, 2023
@urkud urkud removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 14, 2023
@digama0
Copy link
Copy Markdown
Member

digama0 commented Jan 15, 2023

Nice job. Since list.repeat is in core, I guess we need to be careful not to reintroduce uses of it in mathlib. At this point it should be fine to just #align list.repeat List.replicateₓ -- changed argument order and fix any stragglers.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 15, 2023
bors bot pushed a commit that referenced this pull request Jan 15, 2023
This definition differs from `list.repeat` by the order of arguments. The new order is in sync with the Lean 4 version.
@bors
Copy link
Copy Markdown

bors bot commented Jan 15, 2023

Build failed:

@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jan 15, 2023

Try again
bors merge

bors bot pushed a commit that referenced this pull request Jan 15, 2023
This definition differs from `list.repeat` by the order of arguments. The new order is in sync with the Lean 4 version.
@bors
Copy link
Copy Markdown

bors bot commented Jan 15, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(*): define list.replicate and migrate to it [Merged by Bors] - refactor(*): define list.replicate and migrate to it Jan 15, 2023
@bors bors bot closed this Jan 15, 2023
@bors bors bot deleted the YK-list-repeat branch January 15, 2023 09:38
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 16, 2023
Mathlib 3 migrated to `list.replicate` in leanprover-community/mathlib3#18127 (merged) and leanprover-community/mathlib3#18181 (awaiting review).
jcommelin pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 23, 2023
Mathlib 3 migrated to `list.replicate` in leanprover-community/mathlib3#18127 (merged) and leanprover-community/mathlib3#18181 (awaiting review).
eric-wieser added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 21, 2023
This tracks one of the changes in leanprover-community/mathlib3#18127, which for this file was a backport.
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 21, 2023
This tracks one of the changes in leanprover-community/mathlib3#18127, which for this file was a backport.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants