Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/list/count): partially sync with multiset#18125

Closed
urkud wants to merge 2 commits intomasterfrom
YK-count-repeat
Closed

[Merged by Bors] - feat(data/list/count): partially sync with multiset#18125
urkud wants to merge 2 commits intomasterfrom
YK-count-repeat

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jan 11, 2023

  • rename list.count_repeat to list.count_repeat_self;
  • prove list.count_repeat with if .. then .. else in the RHS.

Open in Gitpod

urkud added 2 commits January 10, 2023 14:39
* rename `list.count_repeat` to `list.count_repeat_self`;
* prove `list.count_repeat` with `if .. then .. else` in the RHS.
@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 11, 2023
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Please forward-port the data/list/count.lean changes to mathlib4.

@bors
Copy link
Copy Markdown

bors bot commented Jan 11, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 11, 2023
@eric-wieser
Copy link
Copy Markdown
Member

Oh nevermind, I see you already did.

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 11, 2023
bors bot pushed a commit that referenced this pull request Jan 11, 2023
* rename `list.count_repeat` to `list.count_repeat_self`;
* prove `list.count_repeat` with `if .. then .. else` in the RHS.
@bors
Copy link
Copy Markdown

bors bot commented Jan 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/count): partially sync with multiset [Merged by Bors] - feat(data/list/count): partially sync with multiset Jan 11, 2023
@bors bors bot closed this Jan 11, 2023
@bors bors bot deleted the YK-count-repeat branch January 11, 2023 21:21
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 13, 2023
jcommelin pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants