This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - refactor(*): use option.map₂#18081
Closed
Conversation
YaelDillies
reviewed
Jan 7, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Nice PR! I had seen some of those definitions and thought it would be an improvement to use data.option.n_ary, so I approve!
YaelDillies
reviewed
Jan 8, 2023
…athlib into YK-opt-map2
eric-wieser
reviewed
Jan 13, 2023
eric-wieser
approved these changes
Jan 13, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
I added a handful more id $s, and moved the explanation of their purpose to the module docstring.
Can you make sure you forward port these if appropriate?
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
Thanks! bors merge I don't think that we need this in Mathlib 4 because we don't (and can't) use the "make it irreducible later" trick with Lean 4. |
bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Relevant parts are forward-ported as leanprover-community/mathlib4#1439 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
reviewed
Jan 13, 2023
Collaborator
YaelDillies
left a comment
There was a problem hiding this comment.
Sorry, last minute typo!
|
Canceled. |
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Relevant parts are forward-ported as leanprover-community/mathlib4#1439 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Relevant parts are forward-ported as leanprover-community/mathlib4#1439 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2023
Relevant parts are forward-ported as leanprover-community/mathlib4#1439 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2023
Relevant parts are forward-ported as leanprover-community/mathlib4#1439 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2023
Relevant parts are forward-ported as leanprover-community/mathlib4#1439 Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
option.map₂option.map₂
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 25, 2023
This is a forward-port of leanprover-community/mathlib3#18081
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant parts are forward-ported as leanprover-community/mathlib4#1439