This repository was archived by the owner on Jul 24, 2024. It is now read-only.
feat(geometry/manifold/vector_bundle/tangent): use the new tangent bundle definition in the library#18068
Closed
fpvandoorn wants to merge 163 commits intomasterfrom
Closed
feat(geometry/manifold/vector_bundle/tangent): use the new tangent bundle definition in the library#18068fpvandoorn wants to merge 163 commits intomasterfrom
fpvandoorn wants to merge 163 commits intomasterfrom
Conversation
…t I can reorder arguments
slightly shorter test ci Apply suggestions from code review Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com> clean up `cont_mdiff_on_of_mem_cont_diff_groupoid`
bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
…a smooth vector bundle (#17680) * This defines a tangent bundle as a smooth vector bundle * Currently we still use the old definition in the library (e.g. for `mfderiv`). Therefore we put the new version temporarily in the `hidden` namespace, to avoid a name clash (we could skip this PR and immediately merge #18068, but that will be a big PR). Co-authored by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
|
This PR/issue depends on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geometry.manifold.mfderivand later files.cont_mdiff_at_iff_target, which doesn't hold anymore in the new setting.cont_mdiff_at_total_space, which characterizesC^nmaps into a vector bundle.Co-authored by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com