Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/set/basic): A set is either a subsingleton or nontrivial#17901

Closed
YaelDillies wants to merge 2 commits intomasterfrom
set_subsingleton_or_nontrivial
Closed

[Merged by Bors] - feat(data/set/basic): A set is either a subsingleton or nontrivial#17901
YaelDillies wants to merge 2 commits intomasterfrom
set_subsingleton_or_nontrivial

Conversation

@YaelDillies
Copy link
Copy Markdown
Collaborator

Also make the argument to set.finite_or_infinite explicit.


Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Dec 11, 2022
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Dec 11, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 11, 2022
@YaelDillies
Copy link
Copy Markdown
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 12, 2022
…17901)

Also make the argument to `set.finite_or_infinite` explicit.
@astrainfinita
Copy link
Copy Markdown
Collaborator

Doesn't this need a synchronization PR?

@eric-wieser
Copy link
Copy Markdown
Member

Good point. I don't thing data/set/basic is merged just yet in mathlib 4

@bors
Copy link
Copy Markdown

bors bot commented Dec 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/basic): A set is either a subsingleton or nontrivial [Merged by Bors] - feat(data/set/basic): A set is either a subsingleton or nontrivial Dec 12, 2022
@bors bors bot closed this Dec 12, 2022
@bors bors bot deleted the set_subsingleton_or_nontrivial branch December 12, 2022 12:35
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants