Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - chore(*): add mathlib4 synchronization comments#17686

Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
create-pull-request/patch
Closed

[Merged by Bors] - chore(*): add mathlib4 synchronization comments#17686
github-actions[bot] wants to merge 1 commit intomasterfrom
create-pull-request/patch

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot commented Nov 23, 2022

Regenerated from the port status wiki page.
Relates to the following PRs:


I am a bot; please check that I have not put a comment in a bad place before running bors merge!
If the PRs above don't match the file they are listed after, that means the port status page is wrong.

@github-actions github-actions bot force-pushed the create-pull-request/patch branch from e6c81a5 to c10df17 Compare November 23, 2022 00:20
@github-actions github-actions bot added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. mathlib4-synchronization This PR *only* adds a message to the module doc about synchronization with mathlib4 labels Nov 23, 2022
@ericrbg
Copy link
Copy Markdown
Collaborator

ericrbg commented Nov 23, 2022

This is slightly broken; it mentions the wrong PR about Option/NAry instead of (I think) my PR about HierarchyDesign, and it commented wrong on src/algebra/quotient.lean, which was ported in mathlib4#643 but instead it says that it was ported on "mathlib4#None".

@eric-wieser
Copy link
Copy Markdown
Member

If this is broken, it probably means that something is wrong with the yaml file on the wiki...

@eric-wieser
Copy link
Copy Markdown
Member

I found two entries on the wiki that said mathlib#NNN instead of mathlib4#NNN, let's see if that fixes it.

@eric-wieser
Copy link
Copy Markdown
Member

Yep, here's the other mistake:

algebra.hierarchy_design: Yes mathlib4#656 d8ac338

I guess the bot should include the names of the files next to the PRs so that we can actually spot this without thorough review.

@ericrbg
Copy link
Copy Markdown
Collaborator

ericrbg commented Nov 23, 2022

yep, just looked through.. sorry that was my fault!

@github-actions github-actions bot force-pushed the create-pull-request/patch branch from c10df17 to 635771c Compare November 23, 2022 18:32
@riccardobrasca
Copy link
Copy Markdown
Member

LGTM

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 23, 2022
@github-actions github-actions bot changed the title chore(*): add mathlibport comments chore(*): add mathlib4 synchronization comments Nov 23, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 635771c to e709ebd Compare November 23, 2022 21:17
@bors
Copy link
Copy Markdown

bors bot commented Nov 23, 2022

Canceled.

@github-actions github-actions bot added the awaiting-review The author would like community review of the PR label Nov 23, 2022
@eric-wieser
Copy link
Copy Markdown
Member

bors r-

@eric-wieser
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Nov 23, 2022
@eric-wieser
Copy link
Copy Markdown
Member

#17693 contains the script that was used to generated the updated version

bors bot pushed a commit that referenced this pull request Nov 23, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
@bors
Copy link
Copy Markdown

bors bot commented Nov 23, 2022

Build failed:

@github-actions github-actions bot changed the title chore(*): add mathlib4 synchronization comments chore(*): add mathlibport comments Nov 24, 2022
@github-actions github-actions bot added the awaiting-review The author would like community review of the PR label Nov 24, 2022
@github-actions github-actions bot changed the title chore(*): add mathlibport comments chore(*): add mathlib4 synchronization comments Nov 24, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from e709ebd to e52177b Compare November 24, 2022 18:57
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

@bors
Copy link
Copy Markdown

bors bot commented Nov 24, 2022

Already running a review

@eric-wieser eric-wieser reopened this Nov 24, 2022
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Nov 24, 2022
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

bors bot pushed a commit that referenced this pull request Nov 24, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from e52177b to d99b334 Compare November 25, 2022 00:22
@github-actions github-actions bot added the awaiting-review The author would like community review of the PR label Nov 25, 2022
@bors
Copy link
Copy Markdown

bors bot commented Nov 25, 2022

Canceled.

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the awaiting-review The author would like community review of the PR label Nov 25, 2022
bors bot pushed a commit that referenced this pull request Nov 25, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.opposites`: leanprover-community/mathlib4#644
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
@bors
Copy link
Copy Markdown

bors bot commented Nov 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): add mathlib4 synchronization comments [Merged by Bors] - chore(*): add mathlib4 synchronization comments Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
@bors bors bot deleted the create-pull-request/patch branch November 25, 2022 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

easy < 20s of review time. See the lifecycle page for guidelines. mathlib4-synchronization This PR *only* adds a message to the module doc about synchronization with mathlib4 ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants