This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(geometry/manifold/smooth_manifold_with_corners): define local_homeomorph.extend#17669
Closed
fpvandoorn wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - feat(geometry/manifold/smooth_manifold_with_corners): define local_homeomorph.extend#17669fpvandoorn wants to merge 6 commits intomasterfrom
fpvandoorn wants to merge 6 commits intomasterfrom
Conversation
1 task
sgouezel
reviewed
Nov 25, 2022
| (f.extend I).source ∈ 𝓝[s] x := | ||
| mem_nhds_within_of_mem_nhds $ extend_source_mem_nhds f I h | ||
|
|
||
| lemma extend_continuous_on : continuous_on (f.extend I) (f.extend I).source := |
Collaborator
There was a problem hiding this comment.
Suggested change
| lemma extend_continuous_on : continuous_on (f.extend I) (f.extend I).source := | |
| lemma continuous_on_extend : continuous_on (f.extend I) (f.extend I).source := |
? To match the order of symbols in the lemma statement, in the same way we have continuous_exp in the library and not exp_continuous. Same thing for many lemmas below.
Member
Author
There was a problem hiding this comment.
I reordered a bunch of lemma names, and also renamed the corresponding ext_chart_at lemmas correspondingly. Let me know if I missed any.
Collaborator
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
…meomorph.extend (#17669) * This generalizes the API of `ext_chart_at` to arbitrary local homeomorphisms * This allows us to generalize a bunch of properties of `ext_chart_at` (like smoothness) to arbitrary members of the atlas. * Fix some names: (primed versions are similarly renamed) ``` ext_chart_at_open_source -> is_open_ext_chart_at_source nhds_within_ext_chart_target_eq -> nhds_within_ext_chart_at_target_eq ext_chart_continuous_at_symm -> ext_chart_at_continuous_at_symm ext_chart_continuous_on_symm -> ext_chart_at_continuous_on_symm ext_chart_self_eq -> ext_chart_at_self_eq ext_chart_self_apply -> ext_chart_at_self_apply ext_chart_at_continuous_on -> continuous_on_ext_chart_at ext_chart_at_continuous_at -> continuous_at_ext_chart_at ext_chart_preimage_open_of_open -> is_open_ext_chart_at_preimage ext_chart_at_map_* -> map_ext_chart_at_* ext_chart_at_symm_map_* -> map_ext_chart_at_symm_* ext_chart_preimage_mem_nhds_within -> ext_chart_at_preimage_mem_nhds_within ext_chart_preimage_mem_nhds -> ext_chart_at_preimage_mem_nhds ext_chart_preimage_inter_eq -> ext_chart_at_preimage_inter_eq ext_chart_model_space_eq_id -> ext_chart_at_model_space_eq_id ext_chart_model_space_apply -> ext_chart_at_model_space_apply ``` * One notable unchanged (wrong) name is `mem_ext_chart_source`, but that should be renamed together with `mem_chart_source`. * Motivated by the sphere eversion project
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
…meomorph.extend (#17669) * This generalizes the API of `ext_chart_at` to arbitrary local homeomorphisms * This allows us to generalize a bunch of properties of `ext_chart_at` (like smoothness) to arbitrary members of the atlas. * Fix some names: (primed versions are similarly renamed) ``` ext_chart_at_open_source -> is_open_ext_chart_at_source nhds_within_ext_chart_target_eq -> nhds_within_ext_chart_at_target_eq ext_chart_continuous_at_symm -> ext_chart_at_continuous_at_symm ext_chart_continuous_on_symm -> ext_chart_at_continuous_on_symm ext_chart_self_eq -> ext_chart_at_self_eq ext_chart_self_apply -> ext_chart_at_self_apply ext_chart_at_continuous_on -> continuous_on_ext_chart_at ext_chart_at_continuous_at -> continuous_at_ext_chart_at ext_chart_preimage_open_of_open -> is_open_ext_chart_at_preimage ext_chart_at_map_* -> map_ext_chart_at_* ext_chart_at_symm_map_* -> map_ext_chart_at_symm_* ext_chart_preimage_mem_nhds_within -> ext_chart_at_preimage_mem_nhds_within ext_chart_preimage_mem_nhds -> ext_chart_at_preimage_mem_nhds ext_chart_preimage_inter_eq -> ext_chart_at_preimage_inter_eq ext_chart_model_space_eq_id -> ext_chart_at_model_space_eq_id ext_chart_model_space_apply -> ext_chart_at_model_space_apply ``` * One notable unchanged (wrong) name is `mem_ext_chart_source`, but that should be renamed together with `mem_chart_source`. * Motivated by the sphere eversion project
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext_chart_atto arbitrary local homeomorphismsext_chart_at(like smoothness) to arbitrary members of the atlas.mem_ext_chart_source, but that should be renamed together withmem_chart_source.