This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(tactic/positivity): Extension for ite#17650
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - feat(tactic/positivity): Extension for ite#17650YaelDillies wants to merge 2 commits intomasterfrom
ite#17650YaelDillies wants to merge 2 commits intomasterfrom
Conversation
Member
|
Hi @YaelDillies , now seems like a perfect time to mention that since the |
Collaborator
Author
|
Sorry, I tried understanding what was going on on the mathlib4 side of things but the new meta code completely opaque to me. I cannot even find the counterpart to |
Member
|
positivity_min hasn't been done yet. |
Collaborator
Author
|
Ah then can this be merged now and taken care of on the mathlib4 side later? I can't write the Lean 4 equivalent myself, and this is meta code after all. |
Collaborator
Author
|
Just opened a matching mathlib4 PR, but I didn't to get the extension there working. |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 30, 2023
Match leanprover-community/mathlib3#17650 Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
kbuzzard
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 6, 2023
Match leanprover-community/mathlib3#17650 Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Collaborator
Author
|
Bump here. I still need it in mathlib. |
Collaborator
|
I don't expect there to be any issues here, but I'm going to merge master to be sure. |
Collaborator
|
bors merge |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
iteite
kim-em
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 14, 2023
Match leanprover-community/mathlib3#17650 Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
chenjulang
added a commit
to chenjulang/mathlib
that referenced
this pull request
May 11, 2024
* commit '65a1391a0106c9204fe45bc73a039f056558cb83': (12443 commits)
feat(data/{list,multiset,finset}/*): `attach` and `filter` lemmas (leanprover-community#18087)
feat(combinatorics/simple_graph): More clique lemmas (leanprover-community#19203)
feat(measure_theory/order/upper_lower): Order-connected sets in `ℝⁿ` are measurable (leanprover-community#16976)
move old README.md to OLD_README.md
doc: Add a warning mentioning Lean 4 to the readme (leanprover-community#19243)
feat(topology/metric_space): diameter of pointwise zero and addition (leanprover-community#19028)
feat(topology/algebra/order/liminf_limsup): Eventual boundedness of neighborhoods (leanprover-community#18629)
feat(probability/independence): Independence of singletons (leanprover-community#18506)
feat(combinatorics/set_family/ahlswede_zhang): Ahlswede-Zhang identity, part I (leanprover-community#18612)
feat(data/finset/lattice): `sup'`/`inf'` lemmas (leanprover-community#18989)
chore(order/liminf_limsup): Generalise and move lemmas (leanprover-community#18628)
feat(algebraic_topology/dold_kan): The Dold-Kan equivalence for abelian categories (leanprover-community#17926)
feat(data/sum/interval): The lexicographic sum of two locally finite orders is locally finite (leanprover-community#11352)
feat(analysis/convex/proj_Icc): Extending convex functions (leanprover-community#18797)
feat(algebraic_topology/dold_kan): The Dold-Kan equivalence for pseudoabelian categories (leanprover-community#17925)
feat(measure_theory/measure/haar_quotient): the Unfolding Trick (leanprover-community#18863)
feat(linear_algebra/orientation): add `orientation.reindex` (leanprover-community#19236)
feat(combinatorics/quiver/covering): Definition of coverings and unique lifting of paths (leanprover-community#17828)
feat(set_theory/game/pgame): small sets of pre-games / games / surreals are bounded (leanprover-community#15260)
feat(tactic/positivity): Extension for `ite` (leanprover-community#17650)
...
# Conflicts:
# README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
positivity_ite, an extension forite.Requested by @b-mehta
Match leanprover-community/mathlib4#2273