This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - move(algebra/order/monoid/*): Relocate zero_le_one_class#17646
Closed
YaelDillies wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - move(algebra/order/monoid/*): Relocate zero_le_one_class#17646YaelDillies wants to merge 5 commits intomasterfrom
zero_le_one_class#17646YaelDillies wants to merge 5 commits intomasterfrom
Conversation
Collaborator
|
I fixed one error. Since this is right at the edge of where porting is happening, let's merge asap. bors p=10 bors d+ |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
1 task
Member
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 21, 2022
Move `zero_le_one_class` and `linear_ordered_comm_monoid_with_zero` to `algebra.order.monoid.with_zero`. This makes `algebra.order.monoid.defs` and `algebra.order.monoid.canonical.defs` not depend on `group_with_zero` anymore. And indeed we want to develop the theory of ordered additive and multiplicative monoids before mixing both worlds. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
|
Pull request successfully merged into master. Build succeeded: |
zero_le_one_classzero_le_one_class
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
) #17646 move `zero_le_one_class` to `algebra.order.monoid.with_zero`. This PR split things about `zero_le_one_class` into two files. Also, all lemmas about numerics other than 0 and 1 require typeclass `add_monoid_with_one` now. [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/OfNat)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
zero_le_one_classandlinear_ordered_comm_monoid_with_zerotoalgebra.order.monoid.with_zero. This makesalgebra.order.monoid.defsandalgebra.order.monoid.canonical.defsnot depend ongroup_with_zeroanymore.And indeed we want to develop the theory of ordered additive and multiplicative monoids before mixing both worlds.