This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(geometry/manifold/vector_bundle/basic): smooth vector bundles#17611
Closed
[Merged by Bors] - feat(geometry/manifold/vector_bundle/basic): smooth vector bundles#17611
Conversation
slightly shorter test ci Apply suggestions from code review Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com> clean up `cont_mdiff_on_of_mem_cont_diff_groupoid`
lint
Member
|
merged with master. I'll make changes to incorporate my comment, but feel free to already review |
…t delete some changes to this file, but it's hard to figure out if there are any
sgouezel
reviewed
Mar 3, 2023
Collaborator
sgouezel
left a comment
There was a problem hiding this comment.
This seems to be working very nicely, congrats!
bors d+
|
|
||
| ## Main definitions and constructions | ||
|
|
||
| * `fiber_bundle.charted_space`: A fibre bundle `E` over a base `B` with model fibre `F` is naturally |
Collaborator
There was a problem hiding this comment.
It looks strange to me that the Lean name has fiber_bundle but the docstring talks of fibre bundle. I would uniformize that (or uniformise that, as you like), maybe in a later PR.
|
✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with |
… about fiber bundles/vector bundles.
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
…17611) Definition of smooth vector bundle, and basic constructions (direct sum, pullback, core construction). Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com> Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 11, 2023
SHA-only updates: * leanprover-community/mathlib3#17611 – `CategoryTheory.Sites.Sheaf` already uses `aesop_cat` at this location, nothing to port. * leanprover-community/mathlib3#18742 – fiber spelling, which is all of the changes to `Topology.FiberBundle.Trivialization`, is already in mathlib4. * leanprover-community/mathlib3#18198 – `FunLike` change to `Data.PEquiv` is already in mathlib4. Substantative forward port: * leanprover-community/mathlib3#18520 Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
eric-wieser
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 12, 2023
SHA-only updates: * leanprover-community/mathlib3#17611 – `CategoryTheory.Sites.Sheaf` already uses `aesop_cat` at this location, nothing to port. * leanprover-community/mathlib3#18742 – fiber spelling, which is all of the changes to `Topology.FiberBundle.Trivialization`, is already in mathlib4. * leanprover-community/mathlib3#18198 – `FunLike` change to `Data.PEquiv` is already in mathlib4. Substantative forward port: * leanprover-community/mathlib3#18520 Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of smooth vector bundle, and basic constructions (direct sum, pullback, core construction).
Co-authored-by: Floris van Doorn fpvdoorn@gmail.com
cont_diff_groupoid#17291smooth_fiberwise_lineargroupoid #17302