[Merged by Bors] - feat(topology/order/lower_topology): Introduce the lower topology on a preorder#17426
[Merged by Bors] - feat(topology/order/lower_topology): Introduce the lower topology on a preorder#17426
Conversation
|
Since it's been a while, maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
I have two pending comments above (from a few weeks ago). I'd be happy to see them dealt with before the PR is merged. |
@sgouezel - I think I've expanded everything, but I don't seem to be able to see any comments from you on this PR. Please could you post a direct link to them? Sorry. All I could find open was this comment #17426 (comment) from @YaelDillies - I'd done this some time ago, but forgot to resolve the thread. I've done that now. |
|
Sébastien, I can't find your comments anymore. I think they have been lost to some force-push. |
I've checked my inbox - if @sgouezel had commented on the PR then I should have received an e-mail notification from GitHub. |
sgouezel
left a comment
There was a problem hiding this comment.
Something must have gone wrong somewhere (probably on my side). Here they are again.
| This file introduces the lower topology on a preorder. It is shown that the lower topology on a | ||
| partial order is T₀ and the complements of the upper closures of finite subsets form a basis. |
There was a problem hiding this comment.
Can you explain here what the lower topology here. Ideally, the docstring should be readable by someone who doesn't know the maths. You should also sketch the API here, by explaining that you define a type synonym and giving the main theorems.
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
|
bors r+ |
…a preorder (#17426) This PR introduces the lower topology on a preorder. It is shown that the lower topology on a partial order is T₀ and the non-empty complements of the upper closures of finite subsets form a basis. It is also shown that the lower topology on the product of two `order_bot` spaces coincides with the product topology of the lower topologies on the component spaces. This is used to show that the inf map `(a,b) → a ⊓ b` on a complete lattice is continuous. The motivation for introducing the lower topology to mathlib is that, along with the Scott Topology (`topology.omega_complete_partial_order`) it is used to define the Lawson topology (Gierz et al, Chapter III).
|
Pull request successfully merged into master. Build succeeded: |
… Mathlib (#11710) Introduces the Lawson Topology on a preorder. The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced. A basis for the Lawson Topology is defined and some basic results are established: - An upper set is Lawson open if and only if it is Scott open - A lower set is Lawson closed if and only if it is closed under sups of directed sets - The Lawson topology on a partial order is T₀ Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
… Mathlib (#11710) Introduces the Lawson Topology on a preorder. The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced. A basis for the Lawson Topology is defined and some basic results are established: - An upper set is Lawson open if and only if it is Scott open - A lower set is Lawson closed if and only if it is closed under sups of directed sets - The Lawson topology on a partial order is T₀ Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
… Mathlib (#11710) Introduces the Lawson Topology on a preorder. The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced. A basis for the Lawson Topology is defined and some basic results are established: - An upper set is Lawson open if and only if it is Scott open - A lower set is Lawson closed if and only if it is closed under sups of directed sets - The Lawson topology on a partial order is T₀ Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
This PR introduces the lower topology on a preorder. It is shown that the lower topology on a partial order is T₀ and the non-empty complements of the upper closures of finite subsets form a basis.
It is also shown that the lower topology on the product of two
order_botspaces coincides with the product topology of the lower topologies on the component spaces. This is used to show that the inf map(a,b) → a ⊓ bon a complete lattice is continuous.The motivation for introducing the lower topology to mathlib is that, along with the Scott Topology (
topology.omega_complete_partial_order) it is used to define the Lawson topology (Gierz et al, Chapter III).prodlemmas #17747